* [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir
@ 2025-10-16 9:14 James Le Cuirot
2025-10-22 20:48 ` Nicolas Schier
2025-10-25 21:02 ` Nathan Chancellor
0 siblings, 2 replies; 3+ messages in thread
From: James Le Cuirot @ 2025-10-16 9:14 UTC (permalink / raw)
To: linux-kbuild
Cc: Nathan Chancellor, Nicolas Schier, Masahiro Yamada, Inochi Amaoto,
James Le Cuirot
Commit b5e395653546 ("kbuild: install-extmod-build: Fix build when
specifying KBUILD_OUTPUT") tried to address the "build" variable
expecting a relative path by using `realpath --relative-base=.`, but
this only works when the given directory is below the current directory.
`realpath --relative-to=.` will return a relative path in all cases.
Fixes: b5e395653546 ("kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUT")
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
---
scripts/package/install-extmod-build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/install-extmod-build b/scripts/package/install-extmod-build
index b96538787f3d..054fdf45cc37 100755
--- a/scripts/package/install-extmod-build
+++ b/scripts/package/install-extmod-build
@@ -63,7 +63,7 @@ if [ "${CC}" != "${HOSTCC}" ]; then
# Clear VPATH and srcroot because the source files reside in the output
# directory.
# shellcheck disable=SC2016 # $(MAKE) and $(build) will be expanded by Make
- "${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"$(realpath --relative-base=. "${destdir}")"/scripts
+ "${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"$(realpath --relative-to=. "${destdir}")"/scripts
rm -f "${destdir}/scripts/Kbuild"
fi
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir
2025-10-16 9:14 [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir James Le Cuirot
@ 2025-10-22 20:48 ` Nicolas Schier
2025-10-25 21:02 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Schier @ 2025-10-22 20:48 UTC (permalink / raw)
To: James Le Cuirot
Cc: linux-kbuild, Nathan Chancellor, Masahiro Yamada, Inochi Amaoto
On Thu, Oct 16, 2025 at 10:14:17AM +0100, James Le Cuirot wrote:
> Commit b5e395653546 ("kbuild: install-extmod-build: Fix build when
> specifying KBUILD_OUTPUT") tried to address the "build" variable
> expecting a relative path by using `realpath --relative-base=.`, but
> this only works when the given directory is below the current directory.
> `realpath --relative-to=.` will return a relative path in all cases.
>
> Fixes: b5e395653546 ("kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUT")
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
> scripts/package/install-extmod-build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Nicolas Schier <nsc@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir
2025-10-16 9:14 [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir James Le Cuirot
2025-10-22 20:48 ` Nicolas Schier
@ 2025-10-25 21:02 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2025-10-25 21:02 UTC (permalink / raw)
To: linux-kbuild, James Le Cuirot
Cc: Nathan Chancellor, Nicolas Schier, Masahiro Yamada, Inochi Amaoto
On Thu, 16 Oct 2025 10:14:17 +0100, James Le Cuirot wrote:
> Commit b5e395653546 ("kbuild: install-extmod-build: Fix build when
> specifying KBUILD_OUTPUT") tried to address the "build" variable
> expecting a relative path by using `realpath --relative-base=.`, but
> this only works when the given directory is below the current directory.
> `realpath --relative-to=.` will return a relative path in all cases.
>
>
> [...]
Applied, thanks!
[1/1] kbuild: install-extmod-build: Fix when given dir outside the build dir
https://git.kernel.org/kbuild/c/5ff90d427ef84
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-25 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 9:14 [PATCH] kbuild: install-extmod-build: Fix when given dir outside the build dir James Le Cuirot
2025-10-22 20:48 ` Nicolas Schier
2025-10-25 21:02 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox