Linux kbuild/kconfig development
 help / color / mirror / Atom feed
* [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries
@ 2026-03-18 20:37 Thomas Weißschuh
  2026-03-19 22:30 ` Nathan Chancellor
  2026-03-30 19:30 ` Nicolas Schier
  0 siblings, 2 replies; 5+ messages in thread
From: Thomas Weißschuh @ 2026-03-18 20:37 UTC (permalink / raw)
  To: Christian Heusel, Nathan Chancellor, Nicolas Schier
  Cc: linux-kbuild, linux-kernel, Thomas Weißschuh

The unstripped vDSO files are useful for debugging.
They are provided in the upstream 'linux-headers' package.

Also package them as part of 'make pacman-pkg'.
Make them part of the '-debug' package, as they fit there best.
This differs from the upstream package as that has no '-debug' variant.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
In my opinion the same would be useful for debian and rpm packages.
Maybe we should have install-extmod-debug, similar to
install-extmod-build, to centralize these.
---
 scripts/package/PKGBUILD | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
index 452374d63c24..b1d0c8a9f030 100644
--- a/scripts/package/PKGBUILD
+++ b/scripts/package/PKGBUILD
@@ -121,6 +121,9 @@ _package-debug(){
 	install -Dt "${debugdir}" -m644 vmlinux
 	mkdir -p "${builddir}"
 	ln -sr "${debugdir}/vmlinux" "${builddir}/vmlinux"
+
+	echo "Installing unstripped vDSO(s)..."
+	${MAKE} INSTALL_MOD_PATH="${pkgdir}/usr" vdso_install
 }
 
 for _p in "${pkgname[@]}"; do

---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260318-kbuild-pacman-vdso-install-1a81a947b27a

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries
  2026-03-18 20:37 [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries Thomas Weißschuh
@ 2026-03-19 22:30 ` Nathan Chancellor
  2026-03-30 19:30 ` Nicolas Schier
  1 sibling, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2026-03-19 22:30 UTC (permalink / raw)
  To: Thomas Weißschuh
  Cc: Christian Heusel, Nicolas Schier, linux-kbuild, linux-kernel

On Wed, Mar 18, 2026 at 09:37:20PM +0100, Thomas Weißschuh wrote:
> The unstripped vDSO files are useful for debugging.
> They are provided in the upstream 'linux-headers' package.
> 
> Also package them as part of 'make pacman-pkg'.
> Make them part of the '-debug' package, as they fit there best.
> This differs from the upstream package as that has no '-debug' variant.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Seems reasonable to me.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>

> ---
> In my opinion the same would be useful for debian and rpm packages.
> Maybe we should have install-extmod-debug, similar to
> install-extmod-build, to centralize these.
> ---
>  scripts/package/PKGBUILD | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index 452374d63c24..b1d0c8a9f030 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -121,6 +121,9 @@ _package-debug(){
>  	install -Dt "${debugdir}" -m644 vmlinux
>  	mkdir -p "${builddir}"
>  	ln -sr "${debugdir}/vmlinux" "${builddir}/vmlinux"
> +
> +	echo "Installing unstripped vDSO(s)..."
> +	${MAKE} INSTALL_MOD_PATH="${pkgdir}/usr" vdso_install
>  }
>  
>  for _p in "${pkgname[@]}"; do
> 
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260318-kbuild-pacman-vdso-install-1a81a947b27a
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries
  2026-03-18 20:37 [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries Thomas Weißschuh
  2026-03-19 22:30 ` Nathan Chancellor
@ 2026-03-30 19:30 ` Nicolas Schier
  2026-05-12 22:34   ` Viktor Jägersküpper
  1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Schier @ 2026-03-30 19:30 UTC (permalink / raw)
  To: Christian Heusel, Nathan Chancellor, Thomas Weißschuh
  Cc: Nicolas Schier, linux-kbuild, linux-kernel

On Wed, 18 Mar 2026 21:37:20 +0100, Thomas Weißschuh wrote:
> The unstripped vDSO files are useful for debugging.
> They are provided in the upstream 'linux-headers' package.
> 
> Also package them as part of 'make pacman-pkg'.
> Make them part of the '-debug' package, as they fit there best.
> This differs from the upstream package as that has no '-debug' variant.
> 
> [...]

Applied to kbuild/linux.git (kbuild-next-unstable), thanks!

[1/1] kbuild: pacman-pkg: package unstripped vDSO libraries
      https://git.kernel.org/kbuild/c/165e86c2

Please look out for regression or issue reports or other follow up
comments, as they may result in the patch/series getting dropped,
reverted or modified (e.g. trailers). Patches applied to the
kbuild-next-unstable branch are accepted pending wider testing in
linux-next and any post-commit review; they will generally be moved
to the kbuild-next branch in about a week if no issues are found.

Best regards,
-- 
Nicolas


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries
  2026-03-30 19:30 ` Nicolas Schier
@ 2026-05-12 22:34   ` Viktor Jägersküpper
  2026-05-13 15:37     ` Nicolas Schier
  0 siblings, 1 reply; 5+ messages in thread
From: Viktor Jägersküpper @ 2026-05-12 22:34 UTC (permalink / raw)
  To: Nicolas Schier, Christian Heusel, Nathan Chancellor,
	Thomas Weißschuh
  Cc: linux-kbuild, linux-kernel

Am 30.03.26 um 21:30 schrieb Nicolas Schier:
> On Wed, 18 Mar 2026 21:37:20 +0100, Thomas Weißschuh wrote:
>> The unstripped vDSO files are useful for debugging.
>> They are provided in the upstream 'linux-headers' package.
>>
>> Also package them as part of 'make pacman-pkg'.
>> Make them part of the '-debug' package, as they fit there best.
>> This differs from the upstream package as that has no '-debug' variant.
>>
>> [...]
> 
> Applied to kbuild/linux.git (kbuild-next-unstable), thanks!
> 
> [1/1] kbuild: pacman-pkg: package unstripped vDSO libraries
>       https://git.kernel.org/kbuild/c/165e86c2

I can't find this patch anywhere (mainline, linux-next, kbuild branches),
but there are no further comments on the mailing lists.

Was the patch dropped or did it get lost?

Best regards,
Viktor

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries
  2026-05-12 22:34   ` Viktor Jägersküpper
@ 2026-05-13 15:37     ` Nicolas Schier
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Schier @ 2026-05-13 15:37 UTC (permalink / raw)
  To: Viktor Jägersküpper, Nathan Chancellor
  Cc: Christian Heusel, Thomas Weißschuh, linux-kbuild,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Wed, May 13, 2026 at 12:34:57AM +0200, Viktor Jägersküpper wrote:
> Am 30.03.26 um 21:30 schrieb Nicolas Schier:
> > On Wed, 18 Mar 2026 21:37:20 +0100, Thomas Weißschuh wrote:
> >> The unstripped vDSO files are useful for debugging.
> >> They are provided in the upstream 'linux-headers' package.
> >>
> >> Also package them as part of 'make pacman-pkg'.
> >> Make them part of the '-debug' package, as they fit there best.
> >> This differs from the upstream package as that has no '-debug' variant.
> >>
> >> [...]
> > 
> > Applied to kbuild/linux.git (kbuild-next-unstable), thanks!
> > 
> > [1/1] kbuild: pacman-pkg: package unstripped vDSO libraries
> >       https://git.kernel.org/kbuild/c/165e86c2
> 
> I can't find this patch anywhere (mainline, linux-next, kbuild branches),
> but there are no further comments on the mailing lists.
> 
> Was the patch dropped or did it get lost?

thanks for spotting!  You're right, it got lost.  I have that commit still in my
local git tree but w/o any branch referencing it.  I'm sorry.


Nathan, can you please pick this one up for v7.2?


Kind regards,
Nicolas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-13 15:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 20:37 [PATCH] kbuild: pacman-pkg: package unstripped vDSO libraries Thomas Weißschuh
2026-03-19 22:30 ` Nathan Chancellor
2026-03-30 19:30 ` Nicolas Schier
2026-05-12 22:34   ` Viktor Jägersküpper
2026-05-13 15:37     ` Nicolas Schier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox