From: Nicolas Schier <nsc@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: deb-pkg: allow to set package name version
Date: Wed, 21 Oct 2026 19:03:05 +0200 [thread overview]
Message-ID: <atjwSYKodxdVObA3@levanger> (raw)
In-Reply-To: <atfaLGt-46bVugss@quark2.heme.sigxcpu.org>
On Tue, Oct 20, 2026 at 11:16:28PM +0200, Guido Günther wrote:
> Hi Nicolas,
> On Tue, Oct 20, 2026 at 10:02:25PM +0200, Nicolas Schier wrote:
> > On Mon, Oct 19, 2026 at 09:16:14PM +0200, Guido Günther wrote:
> > > Instead of hardcoding ${KERNELRELEASE} in the package name allow
> > > the user to override this.
> > >
> > > This can be useful if one doesn't want to accumulate different packages
> > > for every commit or micro version bump by setting
> > > KDEB_PKGNAMEVERSION=7.3 or even KDEB_PKGNAMEVERSION=stable.
> >
> > I am not yet convinced, that this is a good idea. Do you want to
> > elaborate a bit more, why you think this is necessary? Have you tested
> > your patch? I don't like that source package name and binary package
> > name divert w/o good reasoning.
>
> The source and the binary package names can already differ due to the
> `KDEB_SOURCENAME` variable (and we're making use of that).
>
> What this patch adds is the ability to control the suffix so we can
> e.g. build a `linux-ng-foo` and a `linux-stable-bar` instead of having a
> linux-image-7.3.17, linux-image-7.3.18 (or with git versions or …). It's
> just about having a bit more control over the generated binary package
> names so we can decide what replaces what on upgrades.
>
> I have tested the patch with and without setting KDEB_PKGNAMEVERSION.
> Without setting this variable nothing should change for existing users.
Ack, thanks for clarification. I'll try to review this next week.
Thanks.
--
Nicolas
prev parent reply other threads:[~2026-10-21 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 19:16 [PATCH] kbuild: deb-pkg: allow to set package name version Guido Günther
2026-10-20 19:16 ` sashiko-bot
2026-10-20 19:48 ` Guido Günther
2026-10-20 20:02 ` Nicolas Schier
2026-10-20 20:16 ` Thomas Weißschuh
2026-10-20 21:16 ` Guido Günther
2026-10-21 17:03 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atjwSYKodxdVObA3@levanger \
--to=nsc@kernel.org \
--cc=agx@sigxcpu.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox