[PATCH v2] selinux: add generated av_permissions.h to targets

[PATCH v2] selinux: add generated av_permissions.h to targets

[Thomas Weißschuh]

av_permissions.h was not declared as a target and therefore not cleaned
up automatically by kbuild.

Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/lkml/CAK7LNATUnCPt03BRFSKh1EH=+Sy0Q48wE4ER0BZdJqOb_44L8w@mail.gmail.com/
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Changes in v2:
- Adopt Masahiro's suggestion
- Link to v1: https://lore.kernel.org/r/20241120-selinux-clean-v1-1-68704e007f7a@linutronix.de
---
I left out the modifications to the grouped target comments.
The current state doesn't hurt and I was not able to come up with
something actually nice.
---
 security/selinux/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index 86f0575f670da66a9dc57e13a236d6a5551af38e..66e56e9011dfa4474ac51f00c7595946785273fe 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -33,11 +33,10 @@ $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
 quiet_cmd_genhdrs = GEN     $(addprefix $(obj)/,$(genhdrs))
       cmd_genhdrs = $< $(addprefix $(obj)/,$(genhdrs))
 
-# see the note above, replace the $targets and 'flask.h' rule with the lines
-# below:
-#  targets += $(genhdrs)
+targets += $(genhdrs)
+
+# see the note above, replace the 'flask.h' rule with the line below:
 #  $(addprefix $(obj)/,$(genhdrs)) &: $(obj)/genheaders FORCE
-targets += flask.h
 $(obj)/flask.h: $(obj)/genheaders FORCE
 	$(call if_changed,genhdrs)
 

---
base-commit: aaf20f870da056752f6386693cc0d8e25421ef35
change-id: 20241120-selinux-clean-dfcd0e7a344b

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH v2] selinux: add generated av_permissions.h to targets

[Masahiro Yamada]

On Wed, Nov 27, 2024 at 7:09 PM Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> av_permissions.h was not declared as a target and therefore not cleaned
> up automatically by kbuild.
>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Link: https://lore.kernel.org/lkml/CAK7LNATUnCPt03BRFSKh1EH=+Sy0Q48wE4ER0BZdJqOb_44L8w@mail.gmail.com/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>


Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>





-- 
Best Regards
Masahiro Yamada

Re: [PATCH v2] selinux: add generated av_permissions.h to targets

[Paul Moore]

On Nov 27, 2024 =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de> wrote:
> 
> av_permissions.h was not declared as a target and therefore not cleaned
> up automatically by kbuild.
> 
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Link: https://lore.kernel.org/lkml/CAK7LNATUnCPt03BRFSKh1EH=+Sy0Q48wE4ER0BZdJqOb_44L8w@mail.gmail.com/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> Changes in v2:
> - Adopt Masahiro's suggestion
> - Link to v1: https://lore.kernel.org/r/20241120-selinux-clean-v1-1-68704e007f7a@linutronix.de
> ---
> I left out the modifications to the grouped target comments.
> The current state doesn't hurt and I was not able to come up with
> something actually nice.
> ---
>  security/selinux/Makefile | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Looks good to me, merging into selinux/dev.  Thanks everyone!

--
paul-moore.com