Re: [PATCH v3 next 02/13] scripts/kallsyms: Improve error reporting

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scripts/kallsyms: incomplete errx() conversion in write_src()
--

commit 74224a3e189e43104e9d68aefe42fe16a066052c
Author: David Laight <david.laight.linux@gmail.com>

scripts/kallsyms: Improve error reporting

This commit converts fatal error reporting in scripts/kallsyms.c to use
err() and errx(), updates the usage message, and adds a --verbose option
for timing output.

> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 140e888bf7133..aa3a8ec83fbb8 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c

[ ... ]

> @@ -490,7 +485,7 @@ static void write_src(FILE *out_bin_file, const char *out_bin_name)
>  			long long offset = table[i]->addr - _text;
>  
>  			if (offset < INT_MIN || offset > INT_MAX) {
> -				fprintf(stderr, "kallsyms failure: "
> +				errx(EXIT_FAILURE, "kallsyms failure: "
>  					"relative symbol value %#llx out of range\n",
>  					table[i]->addr);
>  				exit(EXIT_FAILURE);

[Severity: Low]
Since errx() already prepends the program name, appends a newline, and
does not return, should the "kallsyms failure: " prefix, the trailing
newline, and the unreachable exit(EXIT_FAILURE) call be dropped here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111115911.1142000-1-david.laight.linux@gmail.com?part=2