Re: [PATCH v3 next 07/13] kallsyms: Match compressed tokens on the fly during binary search

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] kallsyms: duplicated paragraph in commit message description
--

commit 997bbc0ca13e8295f645bd1de808235b97a9b662
Author: Jim Cromie <jim.cromie@gmail.com>

kallsyms: Match compressed tokens on the fly during binary search

This commit introduces kallsyms_strcmp_symbol() to compare ASCII symbol
names against compressed symbol tokens on the fly during binary search in
kallsyms_lookup_names(), avoiding full symbol decompression on the stack.

> However, full string expansion at every step is equally wasteful: of
> the ~17 strcmps in the binary search, only the last needs to check
> all N chars in both strings, earlier steps will know +/- outcome at
> char 0,1,2..N-1.
>
> However, full string expansion at every step is equally wasteful: of
> the ~17 strcmp()s in the binary search, only the final matching step
> needs to test all characters.  Earlier non-matching steps diverge at
> the first differing character (0..N-1), but the baseline expands every
> candidate symbol to the stack unconditionally, before comparing.

[Severity: Low]
This isn't a bug, but the commit message duplicates this paragraph, where
the first version looks like an earlier draft of the second.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111115911.1142000-1-david.laight.linux@gmail.com?part=7