From: linux.bhar at gmail.com (Bharath Vedartham)
Subject: [Linux-kernel-mentees] [PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*()
Date: Mon, 19 Aug 2019 01:08:54 +0530 [thread overview]
Message-ID: <1566157135-9423-2-git-send-email-linux.bhar@gmail.com> (raw)
In-Reply-To: <1566157135-9423-1-git-send-email-linux.bhar@gmail.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Ira Weiny <ira.weiny at intel.com>
Cc: John Hubbard <jhubbard at nvidia.com>
Cc: J?r?me Glisse <jglisse at redhat.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Dimitri Sivanich <sivanich at sgi.com>
Cc: Arnd Bergmann <arnd at arndb.de>
Cc: William Kucharski <william.kucharski at oracle.com>
Cc: Christoph Hellwig <hch at lst.de>
Cc: linux-kernel at vger.kernel.org
Cc: linux-mm at kvack.org
Cc: linux-kernel-mentees at lists.linuxfoundation.org
Reviewed-by: Ira Weiny <ira.weiny at intel.com>
Reviewed-by: John Hubbard <jhubbard at nvidia.com>
Reviewed-by: William Kucharski <william.kucharski at oracle.com>
Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
---
drivers/misc/sgi-gru/grufault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
index 4b713a8..61b3447 100644
--- a/drivers/misc/sgi-gru/grufault.c
+++ b/drivers/misc/sgi-gru/grufault.c
@@ -188,7 +188,7 @@ static int non_atomic_pte_lookup(struct vm_area_struct *vma,
if (get_user_pages(vaddr, 1, write ? FOLL_WRITE : 0, &page, NULL) <= 0)
return -EFAULT;
*paddr = page_to_phys(page);
- put_page(page);
+ put_user_page(page);
return 0;
}
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: linux.bhar@gmail.com (Bharath Vedartham)
Subject: [Linux-kernel-mentees] [PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*()
Date: Mon, 19 Aug 2019 01:08:54 +0530 [thread overview]
Message-ID: <1566157135-9423-2-git-send-email-linux.bhar@gmail.com> (raw)
Message-ID: <20190818193854.Gd2xbluOQOyZDCm82aEGcbnjAAazwnzKjzPL0UfoYkU@z> (raw)
In-Reply-To: <1566157135-9423-1-git-send-email-linux.bhar@gmail.com>
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Ira Weiny <ira.weiny at intel.com>
Cc: John Hubbard <jhubbard at nvidia.com>
Cc: J?r?me Glisse <jglisse at redhat.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Dimitri Sivanich <sivanich at sgi.com>
Cc: Arnd Bergmann <arnd at arndb.de>
Cc: William Kucharski <william.kucharski at oracle.com>
Cc: Christoph Hellwig <hch at lst.de>
Cc: linux-kernel at vger.kernel.org
Cc: linux-mm at kvack.org
Cc: linux-kernel-mentees at lists.linuxfoundation.org
Reviewed-by: Ira Weiny <ira.weiny at intel.com>
Reviewed-by: John Hubbard <jhubbard at nvidia.com>
Reviewed-by: William Kucharski <william.kucharski at oracle.com>
Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
---
drivers/misc/sgi-gru/grufault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
index 4b713a8..61b3447 100644
--- a/drivers/misc/sgi-gru/grufault.c
+++ b/drivers/misc/sgi-gru/grufault.c
@@ -188,7 +188,7 @@ static int non_atomic_pte_lookup(struct vm_area_struct *vma,
if (get_user_pages(vaddr, 1, write ? FOLL_WRITE : 0, &page, NULL) <= 0)
return -EFAULT;
*paddr = page_to_phys(page);
- put_page(page);
+ put_user_page(page);
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2019-08-18 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 19:38 [Linux-kernel-mentees] [PATCH v6 0/2] get_user_pages changes linux.bhar
2019-08-18 19:38 ` Bharath Vedartham
2019-08-18 19:38 ` linux.bhar [this message]
2019-08-18 19:38 ` [Linux-kernel-mentees] [PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*() Bharath Vedartham
2019-08-18 19:51 ` linux.bhar
2019-08-18 19:51 ` Bharath Vedartham
2019-08-19 12:56 ` sivanich
2019-08-19 12:56 ` Dimitri Sivanich
2019-08-19 19:06 ` linux.bhar
2019-08-19 19:06 ` Bharath Vedartham
2019-08-19 19:30 ` jhubbard
2019-08-19 19:30 ` John Hubbard
2019-08-20 8:18 ` mhocko
2019-08-20 8:18 ` Michal Hocko
2019-08-20 20:50 ` jhubbard
2019-08-20 20:50 ` John Hubbard
2019-08-20 16:24 ` linux.bhar
2019-08-20 16:24 ` Bharath Vedartham
2019-08-18 19:38 ` [Linux-kernel-mentees] [PATCH 2/2] sgi-gru: Remove uneccessary ifdef for CONFIG_HUGETLB_PAGE linux.bhar
2019-08-18 19:38 ` Bharath Vedartham
2019-08-18 19:51 ` linux.bhar
2019-08-18 19:51 ` Bharath Vedartham
2019-08-19 13:00 ` sivanich
2019-08-19 13:00 ` Dimitri Sivanich
2019-08-19 19:07 ` linux.bhar
2019-08-19 19:07 ` Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566157135-9423-2-git-send-email-linux.bhar@gmail.com \
--to=linux-kernel-mentees@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox