* [PATCH net] net: libwx: Fix the size in RSS hash key population
@ 2025-08-14 16:30 Chandra Mohan Sundar
2025-08-15 19:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Chandra Mohan Sundar @ 2025-08-14 16:30 UTC (permalink / raw)
To: jiawenwu, mengyuanlou, andrew+netdev, davem, edumazet, kuba,
pabeni, shuah, netdev, linux-kernel
Cc: Chandra Mohan Sundar, linux-kernel-mentees
While trying to fill a random RSS key, the size of the pointer
is being used rather than the actual size of the RSS key.
Fix by passing an appropriate value of the RSS key.
This issue was reported by static coverity analyser.
Fixes: eb4898fde1de8 ("net: libwx: add wangxun vf common api")
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
---
drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c
index 5d48df7a849f..3023ea2732ef 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_vf_lib.c
@@ -192,7 +192,7 @@ void wx_setup_vfmrqc_vf(struct wx *wx)
u8 i, j;
/* Fill out hash function seeds */
- netdev_rss_key_fill(wx->rss_key, sizeof(wx->rss_key));
+ netdev_rss_key_fill(wx->rss_key, WX_RSS_KEY_SIZE);
for (i = 0; i < WX_RSS_KEY_SIZE / 4; i++)
wr32(wx, WX_VXRSSRK(i), wx->rss_key[i]);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: libwx: Fix the size in RSS hash key population
2025-08-14 16:30 [PATCH net] net: libwx: Fix the size in RSS hash key population Chandra Mohan Sundar
@ 2025-08-15 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-08-15 19:50 UTC (permalink / raw)
To: Chandra Mohan Sundar
Cc: jiawenwu, mengyuanlou, andrew+netdev, davem, edumazet, kuba,
pabeni, shuah, netdev, linux-kernel, linux-kernel-mentees
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 14 Aug 2025 22:00:10 +0530 you wrote:
> While trying to fill a random RSS key, the size of the pointer
> is being used rather than the actual size of the RSS key.
>
> Fix by passing an appropriate value of the RSS key.
> This issue was reported by static coverity analyser.
>
> Fixes: eb4898fde1de8 ("net: libwx: add wangxun vf common api")
> Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: libwx: Fix the size in RSS hash key population
https://git.kernel.org/netdev/net/c/12da2b92ad50
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-15 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 16:30 [PATCH net] net: libwx: Fix the size in RSS hash key population Chandra Mohan Sundar
2025-08-15 19:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox