From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anshul Dalal <anshulusr@gmail.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add MCP4821
Date: Tue, 19 Dec 2023 09:51:31 +0100 [thread overview]
Message-ID: <1fa6128f-03c1-4f41-8dff-4191893f460c@linaro.org> (raw)
In-Reply-To: <6c1e13b3-28d2-42fc-b9c2-dcfc4793fc39@gmail.com>
On 19/12/2023 09:42, Anshul Dalal wrote:
> On 12/19/23 13:29, Krzysztof Kozlowski wrote:
>> On 18/12/2023 17:47, Anshul Dalal wrote:
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + vdd-supply: true
>>> +
>>> + ldac-gpios:
>>> + description: |
>>> + Active Low LDAC (Latch DAC Input) pin used to update the DAC output.
>>> + maxItems: 1
>>> +
>>> + shdn-gpios:
>>
>> Open gpio-consumer-common.yaml and look at entries there.
>>
>
> Should I name the property `powerdown-gpios` instead of `shdn-gpios` as
> specified in gpio-consumer-common.yaml?
Yes. You can provide the name of actual pin in description.
> Furthermore, do I need to add gpio-consumer-common.yaml as a ref?
No.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-19 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 16:47 [PATCH v3 1/2] dt-bindings: iio: dac: add MCP4821 Anshul Dalal
2023-12-18 16:47 ` [PATCH v3 2/2] iio: dac: driver for MCP4821 Anshul Dalal
2023-12-20 14:26 ` Jonathan Cameron
2023-12-19 7:59 ` [PATCH v3 1/2] dt-bindings: iio: dac: add MCP4821 Krzysztof Kozlowski
2023-12-19 8:42 ` Anshul Dalal
2023-12-19 8:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fa6128f-03c1-4f41-8dff-4191893f460c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox