Re: [PATCH v3 1/2] dt-bindings: iio: dac: add MCP4821

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 18/12/2023 17:47, Anshul Dalal wrote:
> Adds support for MCP48xx series of DACs.
> 
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf #MCP48x1
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf #MCP48x2
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Drop, you added properties after review! Adding properties after the
review invalidates given review. Especially if you add wrong properties.

> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
> 
> ---
> 
> Changes for v3:
> - Added gpios for ldac and shutdown pins
> - Added spi-cpha and spi-cpol for the SPI mode 0 and 3
> 
> Changes for v2:
> - Changed order in device table to numerical
> - Made vdd_supply required
> - Added 'Reviewed-by: Conor Dooley'
> 
> Previous versions:
> v2: https://lore.kernel.org/lkml/20231217180836.584828-1-anshulusr@gmail.com/
> v1: https://lore.kernel.org/lkml/20231117073040.685860-1-anshulusr@gmail.com/
> ---


> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  ldac-gpios:
> +    description: |
> +      Active Low LDAC (Latch DAC Input) pin used to update the DAC output.
> +    maxItems: 1
> +
> +  shdn-gpios:

Open gpio-consumer-common.yaml and look at entries there.


Best regards,
Krzysztof