* [PATCH RESEND] usb: storage: ene_ub6250: Fix right shift warnings
@ 2024-09-12 14:52 Abhishek Tamboli
0 siblings, 0 replies; only message in thread
From: Abhishek Tamboli @ 2024-09-12 14:52 UTC (permalink / raw)
To: stern, gregkh
Cc: skhan, dan.carpenter, rbmarliere, linux-kernel-mentees, linux-usb,
usb-storage, linux-kernel
Change bl_len from u16 to u32 to accommodate the necessary bit shifts.
Fix the following smatch warnings:
drivers/usb/storage/ene_ub6250.c:1509 ms_scsi_read_capacity() warn:
right shifting more than type allows 16 vs 24
drivers/usb/storage/ene_ub6250.c:1510 ms_scsi_read_capacity() warn:
right shifting more than type allows 16 vs 16
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
drivers/usb/storage/ene_ub6250.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
index 97c66c0d91f4..ab6718dc874f 100644
--- a/drivers/usb/storage/ene_ub6250.c
+++ b/drivers/usb/storage/ene_ub6250.c
@@ -1484,7 +1484,7 @@ static int ms_scsi_mode_sense(struct us_data *us, struct scsi_cmnd *srb)
static int ms_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb)
{
u32 bl_num;
- u16 bl_len;
+ u32 bl_len;
unsigned int offset = 0;
unsigned char buf[8];
struct scatterlist *sg = NULL;
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-12 14:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 14:52 [PATCH RESEND] usb: storage: ene_ub6250: Fix right shift warnings Abhishek Tamboli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox