* [PATCH] change strncpy to strscpy strncpy is now depricated. It may not NUL-terminate the destination string, resulting in potential memory content exposures, unbounded reads, or crashes. Link: https://github.com/KSPP/linux/issues/90
@ 2025-04-02 17:33 goralbaris
0 siblings, 0 replies; 3+ messages in thread
From: goralbaris @ 2025-04-02 17:33 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, target-devel, linux-kernel, skhan,
linux-kernel-mentees, goralbaris
The strncpy is depricated.
It may not NUL-terminate the destination string, resulting in potential memory
content exposures, unbounded reads, or crashes. Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: goralbaris <goralbaris@gmail.com>
---
drivers/target/target_core_configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index c40217f44b1b..5c0b74e76be2 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -143,7 +143,7 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item,
}
filp_close(fp, NULL);
- strncpy(db_root, db_root_stage, read_bytes);
+ strscpy(db_root, db_root_stage, read_bytes);
pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root);
r = read_bytes;
@@ -3664,7 +3664,7 @@ static void target_init_dbroot(void)
}
filp_close(fp, NULL);
- strncpy(db_root, db_root_stage, DB_ROOT_LEN);
+ strscpy(db_root, db_root_stage, DB_ROOT_LEN);
pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] change strncpy to strscpy strncpy is now depricated. It may not NUL-terminate the destination string, resulting in potential memory content exposures, unbounded reads, or crashes. Link: https://github.com/KSPP/linux/issues/90
@ 2025-04-02 17:25 goralbaris
2025-04-02 19:14 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: goralbaris @ 2025-04-02 17:25 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, target-devel, linux-kernel, skhan,
linux-kernel-mentees, goralbaris
Signed-off-by: goralbaris <goralbaris@gmail.com>
---
drivers/target/target_core_configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index c40217f44b1b..5c0b74e76be2 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -143,7 +143,7 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item,
}
filp_close(fp, NULL);
- strncpy(db_root, db_root_stage, read_bytes);
+ strscpy(db_root, db_root_stage, read_bytes);
pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root);
r = read_bytes;
@@ -3664,7 +3664,7 @@ static void target_init_dbroot(void)
}
filp_close(fp, NULL);
- strncpy(db_root, db_root_stage, DB_ROOT_LEN);
+ strscpy(db_root, db_root_stage, DB_ROOT_LEN);
pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] change strncpy to strscpy strncpy is now depricated. It may not NUL-terminate the destination string, resulting in potential memory content exposures, unbounded reads, or crashes. Link: https://github.com/KSPP/linux/issues/90
2025-04-02 17:25 goralbaris
@ 2025-04-02 19:14 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-04-02 19:14 UTC (permalink / raw)
To: goralbaris
Cc: martin.petersen, linux-scsi, target-devel, linux-kernel, skhan,
linux-kernel-mentees
On Wed, Apr 02, 2025 at 08:25:04PM +0300, goralbaris wrote:
> Signed-off-by: goralbaris <goralbaris@gmail.com>
I think something went wrong with your subject line :(
Also, don't use your email alias for signed-off-by please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-02 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-02 17:33 [PATCH] change strncpy to strscpy strncpy is now depricated. It may not NUL-terminate the destination string, resulting in potential memory content exposures, unbounded reads, or crashes. Link: https://github.com/KSPP/linux/issues/90 goralbaris
-- strict thread matches above, loose matches on Subject: below --
2025-04-02 17:25 goralbaris
2025-04-02 19:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox