[PATCH] nvmet: replace strncpy with strscpy

[PATCH] nvmet: replace strncpy with strscpy

[Marcelo Moreira]

strncpy() is deprecated due to its lack of NULL-termination
guarantees and unnecessary zero-padding of the destination buffer.
Use strscpy() instead.

Link: https://github.com/KSPP/linux/issues/90

Signed-off-by: Marcelo Moreira <marcelomoreira1905@gmail.com>
---
 drivers/nvme/target/discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c
index df7207640506..c06f3e04296c 100644
--- a/drivers/nvme/target/discovery.c
+++ b/drivers/nvme/target/discovery.c
@@ -119,7 +119,7 @@ static void nvmet_format_discovery_entry(struct nvmf_disc_rsp_page_hdr *hdr,
 	memcpy(e->trsvcid, port->disc_addr.trsvcid, NVMF_TRSVCID_SIZE);
 	memcpy(e->traddr, traddr, NVMF_TRADDR_SIZE);
 	memcpy(e->tsas.common, port->disc_addr.tsas.common, NVMF_TSAS_SIZE);
-	strncpy(e->subnqn, subsys_nqn, NVMF_NQN_SIZE);
+	strscpy(e->subnqn, subsys_nqn, NVMF_NQN_SIZE);
 }
 
 /*
-- 
2.49.0

Re: [PATCH] nvmet: replace strncpy with strscpy

[Christoph Hellwig]

On Mon, Mar 31, 2025 at 09:47:28PM -0300, Marcelo Moreira wrote:
> strncpy() is deprecated due to its lack of NULL-termination
> guarantees and unnecessary zero-padding of the destination buffer.
> Use strscpy() instead.

Nothing explains here why it is deprecated and why the replacement
is better.  And why using memcpy or a seq_buf wasn't considered.

> Link: https://github.com/KSPP/linux/issues/90

And these kinds of links are actively harmful as the point a
commercial entity that can be taken down or changed at any time.
Don't do that.