Re: [PATCH 2/2] riscv: dts: spacemit: Add OrangePi RV2 board device tree

[Yixun Lan <dlan@gentoo.org>]

Hi Hendrik,

On 11:37 Wed 16 Jul     , Hendrik Hammernet wrote:
> Hello,
> 
> Thank you for the review.
> 
> On 7/15/25 12:25, Yixun Lan wrote:
> > On 20:32 Fri 11 Jul     , Hendrik Hamerlinck wrote:
> >
> >> +/* Copyright (c) 2023 Ky, Inc */
> > Copyright should cover current year, which is 2025..
> > what's "Ky" stand for? Can you give a full description here
> Regarding the original copyright:
> This file was based on a version from the Ky, Inc downstream kernel, which
> itself appears to be adapted from earlier SpacemiT sources (dated 2023).
> The Orange Pi RV2 board, however, was only released in 2025, suggesting
> that the Ky version was likely copied and renamed from earlier generic
> SpacemiT files.
> 
> In reviewing the Ky downstream tree, I also noticed that several files had
> their copyright statements overwritten with "Ky, Inc", while the original
> years (e.g., 2023) remained unchanged. This makes the provenance a bit
> unclear.
> 
> Since I've significantly reworked the file for the actual Orange Pi RV2
> hardware, I’d prefer to attribute it under my own name, unless retaining
> the original "Ky, Inc" is required.
> 
Personally, your approach looks good to me

> Please let me know what would be appropriate here.
> 
I'm no expert on this, unless people want the more strict way..

Personally, the dts file already has correct Copyright info with
the "SPDX-License-Identifier" line, additional info gives credits
for people who really contributed on this..

> >> +	memory@0 {
> >> +		device_type = "memory";
> >> +		reg = <0x0 0x00000000 0x0 0x80000000>;
> >> +	};
> >> +
> >> +	memory@100000000 {
> >> +		device_type = "memory";
> >> +		reg = <0x1 0x00000000 0x0 0x80000000>;
> >> +	};
> >> +
> > for the memory nodes, there are 2/4/8GB variants from the Link [1], and
> > you couldn't cover all of them in one dt
> >
> > besides, I thought bootloader (u-boot) will populate these info, right?
> > so the above nodes isn't really necessary
> >
> You're absolutely right, U-Boot does populate this information correctly
> at runtime. I will remove the memory nodes in the next version.
> 
> I also noticed that the aliases section is missing in this version, which
> means the chosen.stdout-path = "serial0" reference won’t resolve unless
> serial0 = &uart0; is defined. I didn't encounter issues during testing
> because I'm overriding the boot command in my Buildroot setup, but I’ll
> add the proper aliases node in the next version to ensure upstream
> compatibility.
> 
right, please!

-- 
Yixun Lan (dlan)