[PATCH] futex: selftests: Add description for futex_wake_op()

[PATCH] futex: selftests: Add description for futex_wake_op()

[Devaansh Kumar]

Signed-off-by: Devaansh Kumar <devaanshk840@gmail.com>
---
 tools/testing/selftests/futex/include/futextest.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/include/futextest.h b/tools/testing/selftests/futex/include/futextest.h
index ddbcfc9b7..c77352b97 100644
--- a/tools/testing/selftests/futex/include/futextest.h
+++ b/tools/testing/selftests/futex/include/futextest.h
@@ -134,7 +134,9 @@ futex_unlock_pi(futex_t *uaddr, int opflags)
 }
 
 /**
- * futex_wake_op() - FIXME: COME UP WITH A GOOD ONE LINE DESCRIPTION
+ * futex_wake_op() - atomically modify uaddr2
+ * @nr_wake:	wake up to this many tasks on uaddr
+ * @nr_wake2:	wake up to this many tasks on uaddr2
  */
 static inline int
 futex_wake_op(futex_t *uaddr, futex_t *uaddr2, int nr_wake, int nr_wake2,
-- 
2.49.0

Re: [PATCH] futex: selftests: Add description for futex_wake_op()

[Greg KH]

On Thu, Aug 07, 2025 at 12:00:26AM +0530, Devaansh Kumar wrote:
> Signed-off-by: Devaansh Kumar <devaanshk840@gmail.com>
> ---
>  tools/testing/selftests/futex/include/futextest.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/futex/include/futextest.h b/tools/testing/selftests/futex/include/futextest.h
> index ddbcfc9b7..c77352b97 100644
> --- a/tools/testing/selftests/futex/include/futextest.h
> +++ b/tools/testing/selftests/futex/include/futextest.h
> @@ -134,7 +134,9 @@ futex_unlock_pi(futex_t *uaddr, int opflags)
>  }
>  
>  /**
> - * futex_wake_op() - FIXME: COME UP WITH A GOOD ONE LINE DESCRIPTION
> + * futex_wake_op() - atomically modify uaddr2
> + * @nr_wake:	wake up to this many tasks on uaddr
> + * @nr_wake2:	wake up to this many tasks on uaddr2
>   */
>  static inline int
>  futex_wake_op(futex_t *uaddr, futex_t *uaddr2, int nr_wake, int nr_wake2,
> -- 
> 2.49.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot