* [PATCH] xen/xenbus: handle pointer to NULL in alloc/free_pdev
@ 2024-05-29 13:19 yskelg
2024-05-29 13:28 ` Jürgen Groß
0 siblings, 1 reply; 2+ messages in thread
From: yskelg @ 2024-05-29 13:19 UTC (permalink / raw)
To: Stefano Stabellini, Juergen Gross, Oleksandr Tyshchenko
Cc: skhan, sj, Austin Kim, shjy180909, linux-kernel, xen-devel,
linux-kernel-mentees, Yunseong Kim
From: Yunseong Kim <yskelg@gmail.com>
Modify 'alloc_pdev()' to set 'pdev->xdev' to NULL
if 'xen_pcibk_init_devices()' fails. This ensures that 'pdev->xdev' does
not point to 'xdev' when 'pdev' is freed.
And modify 'free_pdev()' to set 'pdev' to NULL.
Signed-off-by: Yunseong Kim <yskelg@gmail.com>
---
drivers/xen/xen-pciback/xenbus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index b11e401f1b1e..f1709b8e284a 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -54,6 +54,7 @@ static struct xen_pcibk_device *alloc_pdev(struct xenbus_device *xdev)
INIT_WORK(&pdev->op_work, xen_pcibk_do_op);
if (xen_pcibk_init_devices(pdev)) {
+ pdev->xdev = NULL;
kfree(pdev);
pdev = NULL;
}
@@ -102,6 +103,7 @@ static void free_pdev(struct xen_pcibk_device *pdev)
pdev->xdev = NULL;
kfree(pdev);
+ pdev = NULL;
}
static int xen_pcibk_do_attach(struct xen_pcibk_device *pdev, int gnt_ref,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xen/xenbus: handle pointer to NULL in alloc/free_pdev
2024-05-29 13:19 [PATCH] xen/xenbus: handle pointer to NULL in alloc/free_pdev yskelg
@ 2024-05-29 13:28 ` Jürgen Groß
0 siblings, 0 replies; 2+ messages in thread
From: Jürgen Groß @ 2024-05-29 13:28 UTC (permalink / raw)
To: yskelg, Stefano Stabellini, Oleksandr Tyshchenko
Cc: skhan, sj, Austin Kim, shjy180909, linux-kernel, xen-devel,
linux-kernel-mentees
On 29.05.24 15:19, yskelg@gmail.com wrote:
> From: Yunseong Kim <yskelg@gmail.com>
>
> Modify 'alloc_pdev()' to set 'pdev->xdev' to NULL
> if 'xen_pcibk_init_devices()' fails. This ensures that 'pdev->xdev' does
> not point to 'xdev' when 'pdev' is freed.
> And modify 'free_pdev()' to set 'pdev' to NULL.
>
> Signed-off-by: Yunseong Kim <yskelg@gmail.com>
> ---
> drivers/xen/xen-pciback/xenbus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index b11e401f1b1e..f1709b8e284a 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -54,6 +54,7 @@ static struct xen_pcibk_device *alloc_pdev(struct xenbus_device *xdev)
> INIT_WORK(&pdev->op_work, xen_pcibk_do_op);
>
> if (xen_pcibk_init_devices(pdev)) {
> + pdev->xdev = NULL;
> kfree(pdev);
> pdev = NULL;
> }
> @@ -102,6 +103,7 @@ static void free_pdev(struct xen_pcibk_device *pdev)
> pdev->xdev = NULL;
>
> kfree(pdev);
> + pdev = NULL;
> }
>
> static int xen_pcibk_do_attach(struct xen_pcibk_device *pdev, int gnt_ref,
NAK!
Please stop that nonsense. NULL-ing pointers which have no chance to be used any
more is just adding code for no purpose at all.
Please don't send other iterations of this patch. You are wasting review
bandwidth.
Juergen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-29 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-29 13:19 [PATCH] xen/xenbus: handle pointer to NULL in alloc/free_pdev yskelg
2024-05-29 13:28 ` Jürgen Groß
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox