[PATCH] Documentation/wmi: Fix Typo Error in doc

[PATCH] Documentation/wmi: Fix Typo Error in doc

[Alperen Aksu]

Fix to correct spelling of "Hardware"

Signed-off-by: Alperen Aksu <aksulperen@gmail.com>
---
 Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
index 997263e51a7d..24b027362e93 100644
--- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
     [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data);
     [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data);
     [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data);
-    [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
+    [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
   };
 
   [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]
-- 
2.43.0

Re: [PATCH] Documentation/wmi: Fix Typo Error in doc

[Derek J. Clark]

On August 20, 2025 8:58:35 AM PDT, Alperen Aksu <aksulperen@gmail.com> wrote:
>Fix to correct spelling of "Hardware"
>
Hi Alperen, 

While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.

- Derek

>Signed-off-by: Alperen Aksu <aksulperen@gmail.com>
>---
> Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>index 997263e51a7d..24b027362e93 100644
>--- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>+++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>     [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data);
>     [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data);
>     [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data);
>-    [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
>+    [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
>   };
> 
>   [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]

- Derek

Re: [PATCH] Documentation/wmi: Fix Typo Error in doc

[Ilpo Järvinen]

On Wed, 20 Aug 2025, Derek J. Clark wrote:
> On August 20, 2025 8:58:35 AM PDT, Alperen Aksu <aksulperen@gmail.com> wrote:
> >Fix to correct spelling of "Hardware"
> >
> Hi Alperen, 
> 
> While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.

Yes, I'm not keen on accepting patches like this.

These are hardly something user reads as documentation anyway.

> - Derek
> 
> >Signed-off-by: Alperen Aksu <aksulperen@gmail.com>
> >---
> > Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
> >index 997263e51a7d..24b027362e93 100644
> >--- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
> >+++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
> >@@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
> >     [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data);
> >     [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data);
> >     [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data);
> >-    [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
> >+    [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
> >   };
> > 
> >   [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]
> 
> - Derek
> 

-- 
 i.

Re: [PATCH] Documentation/wmi: Fix Typo Error in doc

[Armin Wolf]

Am 15.09.25 um 12:13 schrieb Ilpo Järvinen:

> On Wed, 20 Aug 2025, Derek J. Clark wrote:
>> On August 20, 2025 8:58:35 AM PDT, Alperen Aksu <aksulperen@gmail.com> wrote:
>>> Fix to correct spelling of "Hardware"
>>>
>> Hi Alperen,
>>
>> While we can fix the spelling of these, they are currently as provided by Lenovo. The spelling error exists in the WMI interfaces and during development we decided to leave them wrong to match.
> Yes, I'm not keen on accepting patches like this.
>
> These are hardly something user reads as documentation anyway.

I agree with Derek, this part of the documentation contains text extracted from the underlying interface description of the device.
While it is true that most WMI MOF descriptions contain spelling mistakes, correcting them just for the documentation serves no
purpose.

So thank you for you effort, but the spelling fix is misplaced here.

Thanks,
Armin Wolf

>> - Derek
>>
>>> Signed-off-by: Alperen Aksu <aksulperen@gmail.com>
>>> ---
>>> Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>>> index 997263e51a7d..24b027362e93 100644
>>> --- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>>> +++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>>> @@ -126,7 +126,7 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
>>>      [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data);
>>>      [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data);
>>>      [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data);
>>> -    [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
>>> +    [WmiMethodId(68), Implemented, Description("Get DGPU Hardware ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data);
>>>    };
>>>
>>>    [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")]
>> - Derek
>>