public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
* [PATCH] docs: ext4: Ammend white space
@ 2025-04-22  5:57 I Hsin Cheng
  2025-04-22 13:30 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: I Hsin Cheng @ 2025-04-22  5:57 UTC (permalink / raw)
  To: tytso
  Cc: adilger.kernel, corbet, linux-ext4, linux-doc, linux-kernel,
	skhan, linux-kernel-mentees, I Hsin Cheng

There should be a white space between the words "block" and "size",
instead of writing them together as "blocksize". Ammend a white space
between them.

Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
---
 Documentation/filesystems/ext4/blockgroup.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/ext4/blockgroup.rst b/Documentation/filesystems/ext4/blockgroup.rst
index ed5a5cac6d40..32a66a956f31 100644
--- a/Documentation/filesystems/ext4/blockgroup.rst
+++ b/Documentation/filesystems/ext4/blockgroup.rst
@@ -108,7 +108,7 @@ block groups which can be described by a single block group descriptor
 block. Since the size of the block group descriptor structure is 64
 bytes, a meta-block group contains 16 block groups for filesystems with
 a 1KB block size, and 64 block groups for filesystems with a 4KB
-blocksize. Filesystems can either be created using this new block group
+block size. Filesystems can either be created using this new block group
 descriptor layout, or existing filesystems can be resized on-line, and
 the field s_first_meta_bg in the superblock will indicate the first
 block group using this new layout.
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: ext4: Ammend white space
  2025-04-22  5:57 [PATCH] docs: ext4: Ammend white space I Hsin Cheng
@ 2025-04-22 13:30 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2025-04-22 13:30 UTC (permalink / raw)
  To: I Hsin Cheng, tytso
  Cc: adilger.kernel, linux-ext4, linux-doc, linux-kernel, skhan,
	linux-kernel-mentees, I Hsin Cheng

I Hsin Cheng <richard120310@gmail.com> writes:

> There should be a white space between the words "block" and "size",
> instead of writing them together as "blocksize". Ammend a white space
> between them.
>
> Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
> ---
>  Documentation/filesystems/ext4/blockgroup.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/blockgroup.rst b/Documentation/filesystems/ext4/blockgroup.rst
> index ed5a5cac6d40..32a66a956f31 100644
> --- a/Documentation/filesystems/ext4/blockgroup.rst
> +++ b/Documentation/filesystems/ext4/blockgroup.rst
> @@ -108,7 +108,7 @@ block groups which can be described by a single block group descriptor
>  block. Since the size of the block group descriptor structure is 64
>  bytes, a meta-block group contains 16 block groups for filesystems with
>  a 1KB block size, and 64 block groups for filesystems with a 4KB
> -blocksize. Filesystems can either be created using this new block group
> +block size. Filesystems can either be created using this new block group
>  descriptor layout, or existing filesystems can be resized on-line, and
>  the field s_first_meta_bg in the superblock will indicate the first
>  block group using this new layout.

Thank you for working to improve the documentation!

If you dig through our documentation, you will see that "blocksize" is
fairly common usage.  Changing them all will result in a fair amount of
churn without much in the way of benefit in either readability or
accuracy.  May I politely suggest focusing on the many real problems our
documentation has instead?

Thanks,

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-22 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22  5:57 [PATCH] docs: ext4: Ammend white space I Hsin Cheng
2025-04-22 13:30 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox