* [PATCH v2] rapidio: fix unused variable warning in rio_cm.c @ 2021-05-06 18:18 Anirudh Rayabharam 2021-05-07 6:39 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Anirudh Rayabharam @ 2021-05-06 18:18 UTC (permalink / raw) To: Matt Porter, Alexandre Bounine; +Cc: linux-kernel-mentees, linux-kernel GCC produces an unused variable warning for 'rc': drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’: drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] The return value of rio_add_outb_message() is assigned to 'rc' but it is never used. Fix this warning by logging an error if 'rc' is non-zero. Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> --- Changes in v2: Log an error instead of just removing 'rc'. v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/ --- drivers/rapidio/rio_cm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c index 50ec53d67a4c..971a36f1a23a 100644 --- a/drivers/rapidio/rio_cm.c +++ b/drivers/rapidio/rio_cm.c @@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot) cm->tx_buf[cm->tx_slot] = req->buffer; rc = rio_add_outb_message(cm->mport, req->rdev, cmbox, req->buffer, req->len); + if (rc) { + riocm_error("Failed to add msg to tx queue (err=%d)", + rc); + } + kfree(req->buffer); kfree(req); -- 2.26.2 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] rapidio: fix unused variable warning in rio_cm.c 2021-05-06 18:18 [PATCH v2] rapidio: fix unused variable warning in rio_cm.c Anirudh Rayabharam @ 2021-05-07 6:39 ` Greg KH 2021-05-07 12:05 ` Anirudh Rayabharam 0 siblings, 1 reply; 4+ messages in thread From: Greg KH @ 2021-05-07 6:39 UTC (permalink / raw) To: Anirudh Rayabharam Cc: Alexandre Bounine, Matt Porter, linux-kernel-mentees, linux-kernel On Thu, May 06, 2021 at 11:48:36PM +0530, Anirudh Rayabharam wrote: > GCC produces an unused variable warning for 'rc': > > drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’: > drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but > not used [-Wunused-but-set-variable] > > The return value of rio_add_outb_message() is assigned to 'rc' but it > is never used. Fix this warning by logging an error if 'rc' is non-zero. > > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> > --- > > Changes in v2: > Log an error instead of just removing 'rc'. > > v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/ > > --- > drivers/rapidio/rio_cm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c > index 50ec53d67a4c..971a36f1a23a 100644 > --- a/drivers/rapidio/rio_cm.c > +++ b/drivers/rapidio/rio_cm.c > @@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot) > cm->tx_buf[cm->tx_slot] = req->buffer; > rc = rio_add_outb_message(cm->mport, req->rdev, cmbox, > req->buffer, req->len); > + if (rc) { > + riocm_error("Failed to add msg to tx queue (err=%d)", > + rc); That's pretty pointless (and no need for {}). If an error happens, properly recover from it, don't just punt and tell the user something bad happened and then ignore it. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] rapidio: fix unused variable warning in rio_cm.c 2021-05-07 6:39 ` Greg KH @ 2021-05-07 12:05 ` Anirudh Rayabharam 2021-05-07 12:16 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Anirudh Rayabharam @ 2021-05-07 12:05 UTC (permalink / raw) To: Greg KH; +Cc: Alexandre Bounine, Matt Porter, linux-kernel-mentees, linux-kernel On Fri, May 07, 2021 at 08:39:21AM +0200, Greg KH wrote: > On Thu, May 06, 2021 at 11:48:36PM +0530, Anirudh Rayabharam wrote: > > GCC produces an unused variable warning for 'rc': > > > > drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’: > > drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but > > not used [-Wunused-but-set-variable] > > > > The return value of rio_add_outb_message() is assigned to 'rc' but it > > is never used. Fix this warning by logging an error if 'rc' is non-zero. > > > > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> > > --- > > > > Changes in v2: > > Log an error instead of just removing 'rc'. > > > > v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/ > > > > --- > > drivers/rapidio/rio_cm.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c > > index 50ec53d67a4c..971a36f1a23a 100644 > > --- a/drivers/rapidio/rio_cm.c > > +++ b/drivers/rapidio/rio_cm.c > > @@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot) > > cm->tx_buf[cm->tx_slot] = req->buffer; > > rc = rio_add_outb_message(cm->mport, req->rdev, cmbox, > > req->buffer, req->len); > > + if (rc) { > > + riocm_error("Failed to add msg to tx queue (err=%d)", > > + rc); > > That's pretty pointless (and no need for {}). The point is that this fixes the compiler warning. I used the {} because I had to split the statement into two lines and thought it is more readable with the {}. checkpatch didn't complain about it either. > > If an error happens, properly recover from it, don't just punt and tell > the user something bad happened and then ignore it. The primary motivation behind this patch is to fix the compiler warning. This error is ignored even in the current tree. My patch at least logs it so that people know that it's happening. And once they know that it's happening and someone wants to propagate the error code to userspace or handle it differently they can write a patch to do so. Thanks! - Anirudh. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] rapidio: fix unused variable warning in rio_cm.c 2021-05-07 12:05 ` Anirudh Rayabharam @ 2021-05-07 12:16 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2021-05-07 12:16 UTC (permalink / raw) To: Anirudh Rayabharam Cc: Alexandre Bounine, Matt Porter, linux-kernel-mentees, linux-kernel On Fri, May 07, 2021 at 05:35:48PM +0530, Anirudh Rayabharam wrote: > On Fri, May 07, 2021 at 08:39:21AM +0200, Greg KH wrote: > > On Thu, May 06, 2021 at 11:48:36PM +0530, Anirudh Rayabharam wrote: > > > GCC produces an unused variable warning for 'rc': > > > > > > drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’: > > > drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but > > > not used [-Wunused-but-set-variable] > > > > > > The return value of rio_add_outb_message() is assigned to 'rc' but it > > > is never used. Fix this warning by logging an error if 'rc' is non-zero. > > > > > > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> > > > --- > > > > > > Changes in v2: > > > Log an error instead of just removing 'rc'. > > > > > > v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/ > > > > > > --- > > > drivers/rapidio/rio_cm.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c > > > index 50ec53d67a4c..971a36f1a23a 100644 > > > --- a/drivers/rapidio/rio_cm.c > > > +++ b/drivers/rapidio/rio_cm.c > > > @@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot) > > > cm->tx_buf[cm->tx_slot] = req->buffer; > > > rc = rio_add_outb_message(cm->mport, req->rdev, cmbox, > > > req->buffer, req->len); > > > + if (rc) { > > > + riocm_error("Failed to add msg to tx queue (err=%d)", > > > + rc); > > > > That's pretty pointless (and no need for {}). > > The point is that this fixes the compiler warning. Don't blindly fix warnings in ways to just shut a compiler up. Fix the issue correctly please. > > If an error happens, properly recover from it, don't just punt and tell > > the user something bad happened and then ignore it. > > The primary motivation behind this patch is to fix the compiler warning. > This error is ignored even in the current tree. My patch at least logs it > so that people know that it's happening. And once they know that it's > happening and someone wants to propagate the error code to userspace or > handle it differently they can write a patch to do so. Please write that patch, as-is, this change is pointless. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-07 12:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-05-06 18:18 [PATCH v2] rapidio: fix unused variable warning in rio_cm.c Anirudh Rayabharam 2021-05-07 6:39 ` Greg KH 2021-05-07 12:05 ` Anirudh Rayabharam 2021-05-07 12:16 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox