* [PATCH] selftests/cgroup: use bash in test_cpuset_v1_hp.sh
@ 2025-02-04 19:29 Bharadwaj Raju
2025-02-04 19:37 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Bharadwaj Raju @ 2025-02-04 19:29 UTC (permalink / raw)
To: tj
Cc: Bharadwaj Raju, hannes, mkoutny, shuah, skhan, cgroups,
linux-kselftest, linux-kernel, linux-kernel-mentees
The script uses non-POSIX features like `[[` for conditionals and hence
does not work when run with a POSIX /bin/sh.
Change the shebang to /bin/bash instead, like the other tests in cgroup.
Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@gmail.com>
---
tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh b/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
index 3f45512fb512..7406c24be1ac 100755
--- a/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
+++ b/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
#
# Test the special cpuset v1 hotplug case where a cpuset become empty of
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/cgroup: use bash in test_cpuset_v1_hp.sh
2025-02-04 19:29 [PATCH] selftests/cgroup: use bash in test_cpuset_v1_hp.sh Bharadwaj Raju
@ 2025-02-04 19:37 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2025-02-04 19:37 UTC (permalink / raw)
To: Bharadwaj Raju
Cc: hannes, mkoutny, shuah, skhan, cgroups, linux-kselftest,
linux-kernel, linux-kernel-mentees
On Wed, Feb 05, 2025 at 12:59:53AM +0530, Bharadwaj Raju wrote:
> The script uses non-POSIX features like `[[` for conditionals and hence
> does not work when run with a POSIX /bin/sh.
>
> Change the shebang to /bin/bash instead, like the other tests in cgroup.
>
> Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@gmail.com>
Applied to cgroup/for-6.14-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-04 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-04 19:29 [PATCH] selftests/cgroup: use bash in test_cpuset_v1_hp.sh Bharadwaj Raju
2025-02-04 19:37 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox