* [PATCH] drm/panel: ili9341: Add comments for ILI9341 register
@ 2024-08-12 17:10 Abhishek Tamboli
2024-08-19 15:41 ` neil.armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Tamboli @ 2024-08-12 17:10 UTC (permalink / raw)
To: neil.armstrong, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel
Cc: quic_jesszhan, dri-devel, skhan, rbmarliere, linux-kernel-mentees,
linux-kernel
TODO : Add missing comments for ILI9341 register definition.
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 775d5d5e828c..cba6a6952568 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -121,19 +121,19 @@ struct ili9341_config {
const struct drm_display_mode mode;
/* ca: TODO: need comments for this register */
u8 ca[ILI9341_CA_LEN];
- /* power_b: TODO: need comments for this register */
+ /* power_b: Power control B (CFh) */
u8 power_b[ILI9341_POWER_B_LEN];
- /* power_seq: TODO: need comments for this register */
+ /* pdtcaower_seq: Power on sequence control (EDh) */
u8 power_seq[ILI9341_POWER_SEQ_LEN];
- /* dtca: TODO: need comments for this register */
+ /* dtca: Driver timing control A (E8h) */
u8 dtca[ILI9341_DTCA_LEN];
- /* dtcb: TODO: need comments for this register */
+ /* dtcb: Driver timing control B (EAh) */
u8 dtcb[ILI9341_DTCB_LEN];
- /* power_a: TODO: need comments for this register */
+ /* power_a: Power control A (CBh) */
u8 power_a[ILI9341_POWER_A_LEN];
/* frc: Frame Rate Control (In Normal Mode/Full Colors) (B1h) */
u8 frc[ILI9341_FRC_LEN];
- /* prc: TODO: need comments for this register */
+ /* prc: Pump ratio control (F7h) */
u8 prc;
/* dfc_1: B6h DISCTRL (Display Function Control) */
u8 dfc_1[ILI9341_DFC_1_LEN];
@@ -147,7 +147,7 @@ struct ili9341_config {
u8 vcom_2;
/* address_mode: Memory Access Control (36h) */
u8 address_mode;
- /* g3amma_en: TODO: need comments for this register */
+ /* g3amma_en: Enable 3G (F2h) */
u8 g3amma_en;
/* rgb_interface: RGB Interface Signal Control (B0h) */
u8 rgb_interface;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register
2024-08-12 17:10 [PATCH] drm/panel: ili9341: Add comments for ILI9341 register Abhishek Tamboli
@ 2024-08-19 15:41 ` neil.armstrong
2024-08-19 17:49 ` Abhishek Tamboli
0 siblings, 1 reply; 3+ messages in thread
From: neil.armstrong @ 2024-08-19 15:41 UTC (permalink / raw)
To: Abhishek Tamboli, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel
Cc: quic_jesszhan, dri-devel, skhan, rbmarliere, linux-kernel-mentees,
linux-kernel
On 12/08/2024 19:10, Abhishek Tamboli wrote:
> TODO : Add missing comments for ILI9341 register definition.
Please rephrase the commit message, and explain why in a proper english sentence.
Neil
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index 775d5d5e828c..cba6a6952568 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -121,19 +121,19 @@ struct ili9341_config {
> const struct drm_display_mode mode;
> /* ca: TODO: need comments for this register */
> u8 ca[ILI9341_CA_LEN];
> - /* power_b: TODO: need comments for this register */
> + /* power_b: Power control B (CFh) */
> u8 power_b[ILI9341_POWER_B_LEN];
> - /* power_seq: TODO: need comments for this register */
> + /* pdtcaower_seq: Power on sequence control (EDh) */
> u8 power_seq[ILI9341_POWER_SEQ_LEN];
> - /* dtca: TODO: need comments for this register */
> + /* dtca: Driver timing control A (E8h) */
> u8 dtca[ILI9341_DTCA_LEN];
> - /* dtcb: TODO: need comments for this register */
> + /* dtcb: Driver timing control B (EAh) */
> u8 dtcb[ILI9341_DTCB_LEN];
> - /* power_a: TODO: need comments for this register */
> + /* power_a: Power control A (CBh) */
> u8 power_a[ILI9341_POWER_A_LEN];
> /* frc: Frame Rate Control (In Normal Mode/Full Colors) (B1h) */
> u8 frc[ILI9341_FRC_LEN];
> - /* prc: TODO: need comments for this register */
> + /* prc: Pump ratio control (F7h) */
> u8 prc;
> /* dfc_1: B6h DISCTRL (Display Function Control) */
> u8 dfc_1[ILI9341_DFC_1_LEN];
> @@ -147,7 +147,7 @@ struct ili9341_config {
> u8 vcom_2;
> /* address_mode: Memory Access Control (36h) */
> u8 address_mode;
> - /* g3amma_en: TODO: need comments for this register */
> + /* g3amma_en: Enable 3G (F2h) */
> u8 g3amma_en;
> /* rgb_interface: RGB Interface Signal Control (B0h) */
> u8 rgb_interface;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register
2024-08-19 15:41 ` neil.armstrong
@ 2024-08-19 17:49 ` Abhishek Tamboli
0 siblings, 0 replies; 3+ messages in thread
From: Abhishek Tamboli @ 2024-08-19 17:49 UTC (permalink / raw)
To: neil.armstrong
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
quic_jesszhan, dri-devel, skhan, rbmarliere, linux-kernel-mentees,
linux-kernel
Hi, Neil
Thanks for the feedback.
On Mon, Aug 19, 2024 at 05:41:07PM +0200, neil.armstrong@linaro.org wrote:
> On 12/08/2024 19:10, Abhishek Tamboli wrote:
> > TODO : Add missing comments for ILI9341 register definition.
>
> Please rephrase the commit message, and explain why in a proper english sentence.
Sure
> Neil
>
> >
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> > ---
> > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > index 775d5d5e828c..cba6a6952568 100644
> > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > @@ -121,19 +121,19 @@ struct ili9341_config {
> > const struct drm_display_mode mode;
> > /* ca: TODO: need comments for this register */
> > u8 ca[ILI9341_CA_LEN];
> > - /* power_b: TODO: need comments for this register */
> > + /* power_b: Power control B (CFh) */
> > u8 power_b[ILI9341_POWER_B_LEN];
> > - /* power_seq: TODO: need comments for this register */
> > + /* pdtcaower_seq: Power on sequence control (EDh) */
> > u8 power_seq[ILI9341_POWER_SEQ_LEN];
> > - /* dtca: TODO: need comments for this register */
> > + /* dtca: Driver timing control A (E8h) */
> > u8 dtca[ILI9341_DTCA_LEN];
> > - /* dtcb: TODO: need comments for this register */
> > + /* dtcb: Driver timing control B (EAh) */
> > u8 dtcb[ILI9341_DTCB_LEN];
> > - /* power_a: TODO: need comments for this register */
> > + /* power_a: Power control A (CBh) */
> > u8 power_a[ILI9341_POWER_A_LEN];
> > /* frc: Frame Rate Control (In Normal Mode/Full Colors) (B1h) */
> > u8 frc[ILI9341_FRC_LEN];
> > - /* prc: TODO: need comments for this register */
> > + /* prc: Pump ratio control (F7h) */
> > u8 prc;
> > /* dfc_1: B6h DISCTRL (Display Function Control) */
> > u8 dfc_1[ILI9341_DFC_1_LEN];
> > @@ -147,7 +147,7 @@ struct ili9341_config {
> > u8 vcom_2;
> > /* address_mode: Memory Access Control (36h) */
> > u8 address_mode;
> > - /* g3amma_en: TODO: need comments for this register */
> > + /* g3amma_en: Enable 3G (F2h) */
> > u8 g3amma_en;
> > /* rgb_interface: RGB Interface Signal Control (B0h) */
> > u8 rgb_interface;
> > --
> > 2.34.1
> >
Regards,
Abhishek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-19 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 17:10 [PATCH] drm/panel: ili9341: Add comments for ILI9341 register Abhishek Tamboli
2024-08-19 15:41 ` neil.armstrong
2024-08-19 17:49 ` Abhishek Tamboli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox