From: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
To: davidgow@google.com
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
skhan@linuxfoundation.org, ricardo@marliere.net,
linux-kernel-mentees@lists.linuxfoundation.org,
andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH v3] lib/math: Add int_sqrt test suite
Date: Sun, 10 Nov 2024 22:39:59 -0500 [thread overview]
Message-ID: <ZzF8j6KT87aj5G0Z@granite.localdomain> (raw)
In-Reply-To: <20241030134355.14294-1-luis.hernandez093@gmail.com>
Hi David,
I wanted to follow up on this patch to check if any additional fixes
are needed. Additionally, I would like to address Andy Shevchenko's
<andriy.shevchenko@linux.intel.com> feedback in v2 regarding moving the
lib/math/test/* Kunit test Kconfig entries from lib/Kconfig.debug
to lib/tests/Kconfig?
> > > > --- a/lib/Kconfig.debug
> > > > +++ b/lib/Kconfig.debug
>
> > > Shouldn't the thing to be in lib/tests/Kconfig?
>
> > The Kconfig entries for lib/math are located in lib/Kconfig.debug as per
> > David Gow in https://lore.kernel.org/all/CABVgOS=-vh5TqHFCq_jo=ffq8v_nGgr6JsPnOZag3e6+19ysxQ@mail.gmail.com/
>
> He put it as "Somehow confusingly, ..." meaning to me as a signal that he will
> agree with me that moving that to lib/tests/Kconfig seems like a right move.
I am happy to make this change if it would be beneficial.
Best,
Felipe
prev parent reply other threads:[~2024-11-11 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 13:43 [PATCH v3] lib/math: Add int_sqrt test suite Luis Felipe Hernandez
2024-10-31 17:50 ` Shuah Khan
2024-11-01 0:39 ` Andrew Morton
2024-11-01 2:25 ` Shuah Khan
2024-11-01 2:28 ` Andrew Morton
2024-11-01 4:27 ` Andrew Morton
2024-11-01 21:01 ` Luis Felipe Hernandez
2024-11-11 3:39 ` Luis Felipe Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzF8j6KT87aj5G0Z@granite.localdomain \
--to=luis.hernandez093@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ricardo@marliere.net \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox