Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

[rujra]

fixed style checks according to Linux Kernel Coding Style standards.


1 : fixed alignment of parenthesis.
LOG : CHECK: Alignment should match open parenthesis
+                       printf("ERROR: out of range value %ld actually set!\n",
+                                       tx.freq);

2 : fixed alignment of parenthesis.
LOG : CHECK: Alignment should match open parenthesis
+                               printf("Error: No failure on invalid
ADJ_FREQUENCY %ld\n",
+                                       invalid_freq[i]);

3 : fixed line length of 106 to 100 and less.
LOG :  CHECK: line length of 106 exceeds 100 columns
+               printf("Invalid (sec: %ld  usec: %ld) did not fail! ",
tmx.time.tv_sec, tmx.time.tv_usec);

Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
---
 tools/testing/selftests/timers/valid-adjtimex.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/timers/valid-adjtimex.c
b/tools/testing/selftests/timers/valid-adjtimex.c
index 6b7801055ad1..5110f9ee285c 100644
--- a/tools/testing/selftests/timers/valid-adjtimex.c
+++ b/tools/testing/selftests/timers/valid-adjtimex.c
@@ -157,7 +157,7 @@ int validate_freq(void)
                if (tx.freq == outofrange_freq[i]) {
                        printf("[FAIL]\n");
                        printf("ERROR: out of range value %ld actually set!\n",
-                                       tx.freq);
+                              tx.freq);
                        pass = -1;
                        goto out;
                }
@@ -172,7 +172,7 @@ int validate_freq(void)
                        if (ret >= 0) {
                                printf("[FAIL]\n");
                                printf("Error: No failure on invalid
ADJ_FREQUENCY %ld\n",
-                                       invalid_freq[i]);
+                                      invalid_freq[i]);
                                pass = -1;
                                goto out;
                        }
@@ -238,7 +238,8 @@ int set_bad_offset(long sec, long usec, int use_nano)
        tmx.time.tv_usec = usec;
        ret = clock_adjtime(CLOCK_REALTIME, &tmx);
        if (ret >= 0) {
-               printf("Invalid (sec: %ld  usec: %ld) did not fail! ",
tmx.time.tv_sec, tmx.time.tv_usec);
+               printf("Invalid (sec: %ld  usec: %ld) did not fail! ",
+                      tmx.time.tv_sec, tmx.time.tv_usec);
                printf("[FAIL]\n");
                return -1;
        }
--
2.43.0

Re: Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

[Shuah Khan]

On 5/15/25 19:44, rujra wrote:
> fixed style checks according to Linux Kernel Coding Style standards.

Fixes

> 
> 
> 1 : fixed alignment of parenthesis.
> LOG : CHECK: Alignment should match open parenthesis
> +                       printf("ERROR: out of range value %ld actually set!\n",
> +                                       tx.freq);
> 
> 2 : fixed alignment of parenthesis.
> LOG : CHECK: Alignment should match open parenthesis
> +                               printf("Error: No failure on invalid
> ADJ_FREQUENCY %ld\n",
> +                                       invalid_freq[i]);
> 
> 3 : fixed line length of 106 to 100 and less.
> LOG :  CHECK: line length of 106 exceeds 100 columns
> +               printf("Invalid (sec: %ld  usec: %ld) did not fail! ",
> tmx.time.tv_sec, tmx.time.tv_usec);

Please refer to a few logs for examples on how to write change logs.
Also check kernel documentation on submitting patches.

thanks,
-- Shuah