From: Oliver Neukum <oneukum@suse.com>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>, stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, usb-storage@lists.one-eyed-alien.net,
linux-usb@vger.kernel.org, skhan@linuxfoundation.org,
dan.carpenter@linaro.org, rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings
Date: Tue, 30 Jul 2024 09:09:05 +0200 [thread overview]
Message-ID: <e72cc56a-3066-4cb8-848d-bfe27a48c095@suse.com> (raw)
In-Reply-To: <20240729182348.451436-1-abhishektamboli9@gmail.com>
On 29.07.24 20:23, Abhishek Tamboli wrote:
> Change bl_len from u16 to u32 to accommodate the necessary bit shifts.
Hi,
while this patch is technically correct, it papers over the issue.
Could you please
1. use a constant, where a constant is used
2. use the macros for converting endianness
Regards
Oliver
next prev parent reply other threads:[~2024-07-30 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 18:23 [PATCH] usb: storage: ene_ub6250: Fix right shift warnings Abhishek Tamboli
2024-07-29 18:34 ` Alan Stern
2024-07-30 7:09 ` Oliver Neukum [this message]
2024-07-30 17:56 ` Abhishek Tamboli
2024-07-31 9:15 ` Oliver Neukum
2024-07-31 14:04 ` Alan Stern
2024-07-31 18:04 ` Abhishek Tamboli
2024-07-31 18:19 ` Alan Stern
2024-07-31 19:18 ` Abhishek Tamboli
2024-08-01 6:54 ` Oliver Neukum
2024-08-01 14:51 ` Alan Stern
2024-09-12 0:45 ` Abhishek Tamboli
2024-09-12 1:24 ` Alan Stern
2024-09-12 5:06 ` Greg KH
2024-09-12 14:50 ` Abhishek Tamboli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72cc56a-3066-4cb8-848d-bfe27a48c095@suse.com \
--to=oneukum@suse.com \
--cc=abhishektamboli9@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rbmarliere@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox