From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Abhishek Tamboli <abhishektamboli9@gmail.com>
Cc: gregkh@linuxfoundation.org, oneukum@suse.com,
usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org,
skhan@linuxfoundation.org, dan.carpenter@linaro.org,
rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings
Date: Thu, 1 Aug 2024 08:54:18 +0200 [thread overview]
Message-ID: <f5d4711f-9b4a-457c-b68c-c2e9aefbe4a8@suse.com> (raw)
In-Reply-To: <b35a344a-018b-44ae-975a-7767a3d5b6ec@rowland.harvard.edu>
On 31.07.24 20:19, Alan Stern wrote:
> On Wed, Jul 31, 2024 at 11:34:45PM +0530, Abhishek Tamboli wrote:
>> On Wed, Jul 31, 2024 at 10:04:33AM -0400, Alan Stern wrote:
Hi,
I should make my reasoning clearer.
>>> Replacing the variable with a constant won't make much difference. The
>>> compiler will realize that bl_len has a constant value and will generate
>>> appropriate code anyway. I think just changing the type is a fine fix.
While that is absolutely true, it kind of removes the reason for the patch
in the first place. The code gcc generates is unlikely to be changed.
We are reacting to a warning an automatic tool generates. That is a good thing.
We should have clean code. The question is how we react to such a report.
It just seems to me that if we fix such a warning, the code should really be clean
after that. Just doing the minimum that will make the checker shut up is
no good.
Regards
Oliver
next prev parent reply other threads:[~2024-08-01 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 18:23 [PATCH] usb: storage: ene_ub6250: Fix right shift warnings Abhishek Tamboli
2024-07-29 18:34 ` Alan Stern
2024-07-30 7:09 ` Oliver Neukum
2024-07-30 17:56 ` Abhishek Tamboli
2024-07-31 9:15 ` Oliver Neukum
2024-07-31 14:04 ` Alan Stern
2024-07-31 18:04 ` Abhishek Tamboli
2024-07-31 18:19 ` Alan Stern
2024-07-31 19:18 ` Abhishek Tamboli
2024-08-01 6:54 ` Oliver Neukum [this message]
2024-08-01 14:51 ` Alan Stern
2024-09-12 0:45 ` Abhishek Tamboli
2024-09-12 1:24 ` Alan Stern
2024-09-12 5:06 ` Greg KH
2024-09-12 14:50 ` Abhishek Tamboli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d4711f-9b4a-457c-b68c-c2e9aefbe4a8@suse.com \
--to=oneukum@suse.com \
--cc=abhishektamboli9@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rbmarliere@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox