* [PATCH] selftests/arm64: Fix typos in malloc return value check
@ 2025-08-24 13:16 Nikola Z. Ivanov
2025-08-24 13:40 ` Markus Elfring
2025-08-25 15:38 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Nikola Z. Ivanov @ 2025-08-24 13:16 UTC (permalink / raw)
To: catalin.marinas, will, shuah, ebiggers, martin.petersen, ardb,
broonie, thiago.bauermann, linux-kselftest
Cc: linux-arm-kernel, linux-kernel, linux-kernel-mentees,
Nikola Z. Ivanov
Fix double "-ed" in malloc return value check
Signed-off-by: Nikola Z. Ivanov <zlatistiv@gmail.com>
---
tools/testing/selftests/arm64/fp/fp-stress.c | 2 +-
tools/testing/selftests/arm64/fp/kernel-test.c | 4 ++--
tools/testing/selftests/arm64/gcs/gcs-stress.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/arm64/fp/fp-stress.c b/tools/testing/selftests/arm64/fp/fp-stress.c
index 74e23208b94c..ddc01efea3f9 100644
--- a/tools/testing/selftests/arm64/fp/fp-stress.c
+++ b/tools/testing/selftests/arm64/fp/fp-stress.c
@@ -549,7 +549,7 @@ int main(int argc, char **argv)
evs = calloc(tests, sizeof(*evs));
if (!evs)
- ksft_exit_fail_msg("Failed to allocated %d epoll events\n",
+ ksft_exit_fail_msg("Failed to allocate %d epoll events\n",
tests);
for (i = 0; i < cpus; i++) {
diff --git a/tools/testing/selftests/arm64/fp/kernel-test.c b/tools/testing/selftests/arm64/fp/kernel-test.c
index e3cec3723ffa..0c40007d1282 100644
--- a/tools/testing/selftests/arm64/fp/kernel-test.c
+++ b/tools/testing/selftests/arm64/fp/kernel-test.c
@@ -188,13 +188,13 @@ static bool create_socket(void)
ref = malloc(digest_len);
if (!ref) {
- printf("Failed to allocated %d byte reference\n", digest_len);
+ printf("Failed to allocate %d byte reference\n", digest_len);
return false;
}
digest = malloc(digest_len);
if (!digest) {
- printf("Failed to allocated %d byte digest\n", digest_len);
+ printf("Failed to allocate %d byte digest\n", digest_len);
return false;
}
diff --git a/tools/testing/selftests/arm64/gcs/gcs-stress.c b/tools/testing/selftests/arm64/gcs/gcs-stress.c
index bbc7f4950c13..cf316d78ea97 100644
--- a/tools/testing/selftests/arm64/gcs/gcs-stress.c
+++ b/tools/testing/selftests/arm64/gcs/gcs-stress.c
@@ -433,7 +433,7 @@ int main(int argc, char **argv)
evs = calloc(tests, sizeof(*evs));
if (!evs)
- ksft_exit_fail_msg("Failed to allocated %d epoll events\n",
+ ksft_exit_fail_msg("Failed to allocate %d epoll events\n",
tests);
for (i = 0; i < gcs_threads; i++)
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] selftests/arm64: Fix typos in malloc return value check
2025-08-24 13:16 [PATCH] selftests/arm64: Fix typos in malloc return value check Nikola Z. Ivanov
@ 2025-08-24 13:40 ` Markus Elfring
2025-08-25 13:06 ` Bagas Sanjaya
2025-08-25 15:38 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2025-08-24 13:40 UTC (permalink / raw)
To: Nikola Z. Ivanov, linux-kselftest, linux-kernel-mentees,
linux-arm-kernel
Cc: LKML, Ard Biesheuvel, Catalin Marinas, Eric Biggers, Mark Brown,
Martin K. Petersen, Shuah Khan, Thiago Jung Bauermann,
Will Deacon
> Fix double "-ed" in malloc return value check
Refine wordings in error message string literals?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/arm64: Fix typos in malloc return value check
2025-08-24 13:40 ` Markus Elfring
@ 2025-08-25 13:06 ` Bagas Sanjaya
2025-08-25 15:44 ` Nikola Z. Ivanov
0 siblings, 1 reply; 6+ messages in thread
From: Bagas Sanjaya @ 2025-08-25 13:06 UTC (permalink / raw)
To: Markus Elfring, Nikola Z. Ivanov, linux-kselftest,
linux-kernel-mentees, linux-arm-kernel
Cc: LKML, Ard Biesheuvel, Catalin Marinas, Eric Biggers, Mark Brown,
Martin K. Petersen, Shuah Khan, Thiago Jung Bauermann,
Will Deacon
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
> > Fix double "-ed" in malloc return value check
>
> Refine wordings in error message string literals?
>
I think what the patch author (Nikola) intends is "The error messages' wording
use parallel structure device, where the second verb should've been in
infinitives form. Correct it."
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/arm64: Fix typos in malloc return value check
2025-08-25 13:06 ` Bagas Sanjaya
@ 2025-08-25 15:44 ` Nikola Z. Ivanov
2025-08-26 0:01 ` Bagas Sanjaya
0 siblings, 1 reply; 6+ messages in thread
From: Nikola Z. Ivanov @ 2025-08-25 15:44 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Markus Elfring, linux-kselftest, linux-kernel-mentees,
linux-arm-kernel, LKML, Ard Biesheuvel, Catalin Marinas,
Eric Biggers, Mark Brown, Martin K. Petersen, Shuah Khan,
Thiago Jung Bauermann, Will Deacon
On Mon, Aug 25, 2025 at 08:06:29PM +0700, Bagas Sanjaya wrote:
> On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
> > > Fix double "-ed" in malloc return value check
> >
> > Refine wordings in error message string literals?
> >
>
> I think what the patch author (Nikola) intends is "The error messages' wording
> use parallel structure device, where the second verb should've been in
> infinitives form. Correct it."
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
Thanks, I did not expect to get schooled like this (in a good way of
course). Should I send v2?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/arm64: Fix typos in malloc return value check
2025-08-25 15:44 ` Nikola Z. Ivanov
@ 2025-08-26 0:01 ` Bagas Sanjaya
0 siblings, 0 replies; 6+ messages in thread
From: Bagas Sanjaya @ 2025-08-26 0:01 UTC (permalink / raw)
To: Nikola Z. Ivanov
Cc: Markus Elfring, linux-kselftest, linux-kernel-mentees,
linux-arm-kernel, LKML, Ard Biesheuvel, Catalin Marinas,
Eric Biggers, Mark Brown, Martin K. Petersen, Shuah Khan,
Thiago Jung Bauermann, Will Deacon
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Mon, Aug 25, 2025 at 06:44:23PM +0300, Nikola Z. Ivanov wrote:
> On Mon, Aug 25, 2025 at 08:06:29PM +0700, Bagas Sanjaya wrote:
> > On Sun, Aug 24, 2025 at 03:40:44PM +0200, Markus Elfring wrote:
> > > > Fix double "-ed" in malloc return value check
> > >
> > > Refine wordings in error message string literals?
> > >
> >
> > I think what the patch author (Nikola) intends is "The error messages' wording
> > use parallel structure device, where the second verb should've been in
> > infinitives form. Correct it."
> >
> > Thanks.
> >
> > --
> > An old man doll... just what I always wanted! - Clara
>
> Thanks, I did not expect to get schooled like this (in a good way of
> course). Should I send v2?
Sure.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests/arm64: Fix typos in malloc return value check
2025-08-24 13:16 [PATCH] selftests/arm64: Fix typos in malloc return value check Nikola Z. Ivanov
2025-08-24 13:40 ` Markus Elfring
@ 2025-08-25 15:38 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2025-08-25 15:38 UTC (permalink / raw)
To: Nikola Z. Ivanov
Cc: catalin.marinas, will, shuah, ebiggers, martin.petersen, ardb,
thiago.bauermann, linux-kselftest, linux-arm-kernel, linux-kernel,
linux-kernel-mentees
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
On Sun, Aug 24, 2025 at 04:16:47PM +0300, Nikola Z. Ivanov wrote:
> Fix double "-ed" in malloc return value check
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-08-26 0:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-24 13:16 [PATCH] selftests/arm64: Fix typos in malloc return value check Nikola Z. Ivanov
2025-08-24 13:40 ` Markus Elfring
2025-08-25 13:06 ` Bagas Sanjaya
2025-08-25 15:44 ` Nikola Z. Ivanov
2025-08-26 0:01 ` Bagas Sanjaya
2025-08-25 15:38 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox