* [PATCH] selftests: net: fix spelling and grammar mistakes @ 2025-05-17 1:59 Praveen Balakrishnan 2025-05-22 22:50 ` Shuah Khan 0 siblings, 1 reply; 6+ messages in thread From: Praveen Balakrishnan @ 2025-05-17 1:59 UTC (permalink / raw) To: shuah Cc: Praveen Balakrishnan, linux-kselftest, linux-kernel, skhan, linux-kernel-mentees Fix several spelling and grammatical mistakes in output messages from the net selftests to improve readability. Only the message strings for the test output have been modified. No changes to the functional logic of the tests have been made. Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> --- .../testing/selftests/net/netfilter/conntrack_vrf.sh | 4 ++-- tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +- tools/testing/selftests/net/rps_default_mask.sh | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/netfilter/conntrack_vrf.sh b/tools/testing/selftests/net/netfilter/conntrack_vrf.sh index e95ecb37c2b1..806d2bfbd6e7 100755 --- a/tools/testing/selftests/net/netfilter/conntrack_vrf.sh +++ b/tools/testing/selftests/net/netfilter/conntrack_vrf.sh @@ -236,9 +236,9 @@ EOF ip netns exec "$ns1" ping -q -w 1 -c 1 "$DUMMYNET".2 > /dev/null if ip netns exec "$ns0" nft list counter t fibcount | grep -q "packets 1"; then - echo "PASS: fib lookup returned exepected output interface" + echo "PASS: fib lookup returned expected output interface" else - echo "FAIL: fib lookup did not return exepected output interface" + echo "FAIL: fib lookup did not return expected output interface" ret=1 return fi diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py index 8a0396bfaf99..b521e0dea506 100644 --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py @@ -1877,7 +1877,7 @@ class OvsPacket(GenericNetlinkSocket): elif msg["cmd"] == OvsPacket.OVS_PACKET_CMD_EXECUTE: up.execute(msg) else: - print("Unkonwn cmd: %d" % msg["cmd"]) + print("Unknown cmd: %d" % msg["cmd"]) except NetlinkError as ne: raise ne diff --git a/tools/testing/selftests/net/rps_default_mask.sh b/tools/testing/selftests/net/rps_default_mask.sh index 4287a8529890..b200019b3c80 100755 --- a/tools/testing/selftests/net/rps_default_mask.sh +++ b/tools/testing/selftests/net/rps_default_mask.sh @@ -54,16 +54,16 @@ cleanup echo 1 > /proc/sys/net/core/rps_default_mask setup -chk_rps "changing rps_default_mask dont affect existing devices" "" lo $INITIAL_RPS_DEFAULT_MASK +chk_rps "changing rps_default_mask doesn't affect existing devices" "" lo $INITIAL_RPS_DEFAULT_MASK echo 3 > /proc/sys/net/core/rps_default_mask -chk_rps "changing rps_default_mask dont affect existing netns" $NETNS lo 0 +chk_rps "changing rps_default_mask doesn't affect existing netns" $NETNS lo 0 ip link add name $VETH type veth peer netns $NETNS name $VETH ip link set dev $VETH up ip -n $NETNS link set dev $VETH up -chk_rps "changing rps_default_mask affect newly created devices" "" $VETH 3 -chk_rps "changing rps_default_mask don't affect newly child netns[II]" $NETNS $VETH 0 +chk_rps "changing rps_default_mask affects newly created devices" "" $VETH 3 +chk_rps "changing rps_default_mask doesn't affect newly child netns[II]" $NETNS $VETH 0 ip link del dev $VETH ip netns del $NETNS @@ -72,8 +72,8 @@ chk_rps "rps_default_mask is 0 by default in child netns" "$NETNS" lo 0 ip netns exec $NETNS sysctl -qw net.core.rps_default_mask=1 ip link add name $VETH type veth peer netns $NETNS name $VETH -chk_rps "changing rps_default_mask in child ns don't affect the main one" "" lo $INITIAL_RPS_DEFAULT_MASK +chk_rps "changing rps_default_mask in child ns doesn't affect the main one" "" lo $INITIAL_RPS_DEFAULT_MASK chk_rps "changing rps_default_mask in child ns affects new childns devices" $NETNS $VETH 1 -chk_rps "changing rps_default_mask in child ns don't affect existing devices" $NETNS lo 0 +chk_rps "changing rps_default_mask in child ns doesn't affect existing devices" $NETNS lo 0 exit $ret -- 2.39.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] selftests: net: fix spelling and grammar mistakes 2025-05-17 1:59 [PATCH] selftests: net: fix spelling and grammar mistakes Praveen Balakrishnan @ 2025-05-22 22:50 ` Shuah Khan 2025-05-23 2:22 ` [PATCH v2] " Praveen Balakrishnan 0 siblings, 1 reply; 6+ messages in thread From: Shuah Khan @ 2025-05-22 22:50 UTC (permalink / raw) To: Praveen Balakrishnan, shuah Cc: linux-kselftest, linux-kernel, linux-kernel-mentees On 5/16/25 19:59, Praveen Balakrishnan wrote: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> This patch is missing net maintainers. RUn get_maintainers.pl for complete list recipients for this patch. thanks, -- Shuah ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] selftests: net: fix spelling and grammar mistakes 2025-05-22 22:50 ` Shuah Khan @ 2025-05-23 2:22 ` Praveen Balakrishnan 2025-05-23 13:08 ` Simon Horman ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Praveen Balakrishnan @ 2025-05-23 2:22 UTC (permalink / raw) To: pablo, kadlec, davem, edumazet, kuba, pabeni, horms, shuah, aconole, echaudro, i.maximets Cc: Praveen Balakrishnan, netfilter-devel, coreteam, netdev, linux-kselftest, linux-kernel, skhan, linux-kernel-mentees Fix several spelling and grammatical mistakes in output messages from the net selftests to improve readability. Only the message strings for the test output have been modified. No changes to the functional logic of the tests have been made. Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> --- Changes in v2: - Resending to full recipient list as requested by Shuah Khan. No code changes since v1. .../testing/selftests/net/netfilter/conntrack_vrf.sh | 4 ++-- tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +- tools/testing/selftests/net/rps_default_mask.sh | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/netfilter/conntrack_vrf.sh b/tools/testing/selftests/net/netfilter/conntrack_vrf.sh index e95ecb37c2b1..806d2bfbd6e7 100755 --- a/tools/testing/selftests/net/netfilter/conntrack_vrf.sh +++ b/tools/testing/selftests/net/netfilter/conntrack_vrf.sh @@ -236,9 +236,9 @@ EOF ip netns exec "$ns1" ping -q -w 1 -c 1 "$DUMMYNET".2 > /dev/null if ip netns exec "$ns0" nft list counter t fibcount | grep -q "packets 1"; then - echo "PASS: fib lookup returned exepected output interface" + echo "PASS: fib lookup returned expected output interface" else - echo "FAIL: fib lookup did not return exepected output interface" + echo "FAIL: fib lookup did not return expected output interface" ret=1 return fi diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py index 8a0396bfaf99..b521e0dea506 100644 --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py @@ -1877,7 +1877,7 @@ class OvsPacket(GenericNetlinkSocket): elif msg["cmd"] == OvsPacket.OVS_PACKET_CMD_EXECUTE: up.execute(msg) else: - print("Unkonwn cmd: %d" % msg["cmd"]) + print("Unknown cmd: %d" % msg["cmd"]) except NetlinkError as ne: raise ne diff --git a/tools/testing/selftests/net/rps_default_mask.sh b/tools/testing/selftests/net/rps_default_mask.sh index 4287a8529890..b200019b3c80 100755 --- a/tools/testing/selftests/net/rps_default_mask.sh +++ b/tools/testing/selftests/net/rps_default_mask.sh @@ -54,16 +54,16 @@ cleanup echo 1 > /proc/sys/net/core/rps_default_mask setup -chk_rps "changing rps_default_mask dont affect existing devices" "" lo $INITIAL_RPS_DEFAULT_MASK +chk_rps "changing rps_default_mask doesn't affect existing devices" "" lo $INITIAL_RPS_DEFAULT_MASK echo 3 > /proc/sys/net/core/rps_default_mask -chk_rps "changing rps_default_mask dont affect existing netns" $NETNS lo 0 +chk_rps "changing rps_default_mask doesn't affect existing netns" $NETNS lo 0 ip link add name $VETH type veth peer netns $NETNS name $VETH ip link set dev $VETH up ip -n $NETNS link set dev $VETH up -chk_rps "changing rps_default_mask affect newly created devices" "" $VETH 3 -chk_rps "changing rps_default_mask don't affect newly child netns[II]" $NETNS $VETH 0 +chk_rps "changing rps_default_mask affects newly created devices" "" $VETH 3 +chk_rps "changing rps_default_mask doesn't affect newly child netns[II]" $NETNS $VETH 0 ip link del dev $VETH ip netns del $NETNS @@ -72,8 +72,8 @@ chk_rps "rps_default_mask is 0 by default in child netns" "$NETNS" lo 0 ip netns exec $NETNS sysctl -qw net.core.rps_default_mask=1 ip link add name $VETH type veth peer netns $NETNS name $VETH -chk_rps "changing rps_default_mask in child ns don't affect the main one" "" lo $INITIAL_RPS_DEFAULT_MASK +chk_rps "changing rps_default_mask in child ns doesn't affect the main one" "" lo $INITIAL_RPS_DEFAULT_MASK chk_rps "changing rps_default_mask in child ns affects new childns devices" $NETNS $VETH 1 -chk_rps "changing rps_default_mask in child ns don't affect existing devices" $NETNS lo 0 +chk_rps "changing rps_default_mask in child ns doesn't affect existing devices" $NETNS lo 0 exit $ret -- 2.39.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes 2025-05-23 2:22 ` [PATCH v2] " Praveen Balakrishnan @ 2025-05-23 13:08 ` Simon Horman 2025-05-23 17:29 ` Aaron Conole 2025-05-28 1:18 ` Jakub Kicinski 2 siblings, 0 replies; 6+ messages in thread From: Simon Horman @ 2025-05-23 13:08 UTC (permalink / raw) To: Praveen Balakrishnan Cc: pablo, kadlec, davem, edumazet, kuba, pabeni, shuah, aconole, echaudro, i.maximets, netfilter-devel, coreteam, netdev, linux-kselftest, linux-kernel, skhan, linux-kernel-mentees On Fri, May 23, 2025 at 03:22:42AM +0100, Praveen Balakrishnan wrote: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> > --- > Changes in v2: > - Resending to full recipient list as requested by Shuah Khan. No code > changes since v1. Thanks, I agree these are all good improvements. Reviewed-by: Simon Horman <horms@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes 2025-05-23 2:22 ` [PATCH v2] " Praveen Balakrishnan 2025-05-23 13:08 ` Simon Horman @ 2025-05-23 17:29 ` Aaron Conole 2025-05-28 1:18 ` Jakub Kicinski 2 siblings, 0 replies; 6+ messages in thread From: Aaron Conole @ 2025-05-23 17:29 UTC (permalink / raw) To: Praveen Balakrishnan Cc: pablo, kadlec, davem, edumazet, kuba, pabeni, horms, shuah, echaudro, i.maximets, netfilter-devel, coreteam, netdev, linux-kselftest, linux-kernel, skhan, linux-kernel-mentees Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> writes: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> > --- LGTM - thanks for fixing the ovs-dpctl.py output. For the OVS test Reviewed-by: Aaron Conole <aconole@redhat.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] selftests: net: fix spelling and grammar mistakes 2025-05-23 2:22 ` [PATCH v2] " Praveen Balakrishnan 2025-05-23 13:08 ` Simon Horman 2025-05-23 17:29 ` Aaron Conole @ 2025-05-28 1:18 ` Jakub Kicinski 2 siblings, 0 replies; 6+ messages in thread From: Jakub Kicinski @ 2025-05-28 1:18 UTC (permalink / raw) To: Praveen Balakrishnan Cc: pablo, kadlec, davem, edumazet, pabeni, horms, shuah, aconole, echaudro, i.maximets, netfilter-devel, coreteam, netdev, linux-kselftest, linux-kernel, skhan, linux-kernel-mentees On Fri, 23 May 2025 03:22:42 +0100 Praveen Balakrishnan wrote: > Fix several spelling and grammatical mistakes in output messages from > the net selftests to improve readability. > > Only the message strings for the test output have been modified. No > changes to the functional logic of the tests have been made. > > Signed-off-by: Praveen Balakrishnan <praveen.balakrishnan@magd.ox.ac.uk> This does not apply cleanly any more. Please wait until net-next re-opens after the merge window, rebase and repost: https://netdev.bots.linux.dev/net-next.html -- pw-bot: cr ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-28 1:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-05-17 1:59 [PATCH] selftests: net: fix spelling and grammar mistakes Praveen Balakrishnan 2025-05-22 22:50 ` Shuah Khan 2025-05-23 2:22 ` [PATCH v2] " Praveen Balakrishnan 2025-05-23 13:08 ` Simon Horman 2025-05-23 17:29 ` Aaron Conole 2025-05-28 1:18 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox