From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>, Kees Cook <kees@kernel.org>,
David Gow <davidgow@google.com>,
Vitor Massaru Iha <vitor@massaru.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: user: remove user suite
Date: Fri, 26 Jul 2024 13:16:15 +0500 [thread overview]
Message-ID: <01d804a2-3370-44ec-af99-c21af5df0bde@collabora.com> (raw)
In-Reply-To: <23d0926f-293d-4a8c-b503-bd8b2253b7a8@linuxfoundation.org>
On 7/25/24 7:44 PM, Shuah Khan wrote:
> On 7/25/24 05:08, Muhammad Usama Anjum wrote:
>> The user test suite has only one test, test_user_copy which loads
>> test_user_copy module for testing. But test_user_copy module has already
>> been converted to kunit (see fixes). Hence remove the entire suite.
>>
>> Fixes: cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test")
>
> Remove fixes tag - this isn't a fix and we don't want this propagating
> to stable releases without kunit test for this.
The user test suite has been failing since cf6219ee889f as the test module
wasn't found. So this is fixing the failure of kselftest. It just causes
noise and may mask other failures. If you still think that fixes isn't
needed, I can send a new version by removing the fixes tag.
>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>
> Thanks,
> -- Shuah
>
>
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-07-26 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 11:08 [PATCH] selftests: user: remove user suite Muhammad Usama Anjum
2024-07-25 14:44 ` Shuah Khan
2024-07-26 8:16 ` Muhammad Usama Anjum [this message]
2024-07-26 17:19 ` Shuah Khan
2024-07-29 7:18 ` Muhammad Usama Anjum
2024-07-30 22:36 ` Shuah Khan
2024-07-31 2:33 ` Kees Cook
2024-07-31 5:13 ` Muhammad Usama Anjum
2024-07-31 18:12 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d804a2-3370-44ec-af99-c21af5df0bde@collabora.com \
--to=usama.anjum@collabora.com \
--cc=davidgow@google.com \
--cc=kees@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox