Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Shuah Khan <shuah@kernel.org>, Kees Cook <kees@kernel.org>,
	David Gow <davidgow@google.com>,
	Vitor Massaru Iha <vitor@massaru.org>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: user: remove user suite
Date: Tue, 30 Jul 2024 16:36:11 -0600	[thread overview]
Message-ID: <16f14d1a-56f2-4c2c-8180-74ad9bee0182@linuxfoundation.org> (raw)
In-Reply-To: <23d0926f-293d-4a8c-b503-bd8b2253b7a8@linuxfoundation.org>

On 7/25/24 08:44, Shuah Khan wrote:
> On 7/25/24 05:08, Muhammad Usama Anjum wrote:
>> The user test suite has only one test, test_user_copy which loads
>> test_user_copy module for testing. But test_user_copy module has already
>> been converted to kunit (see fixes). Hence remove the entire suite.
>>
>> Fixes: cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test")
> 
> Remove fixes tag - this isn't a fix and we don't want this propagating
> to stable releases without kunit test for this.
> 
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
> 
> Thanks,
> -- Shuah
> 

As mentioned in other threads on this conversion to kunit and removal
of kselfttest - NACK on this patch.

Please don't send me any more of these conversion and removal patches.

thanks,
-- Shuah

  parent reply	other threads:[~2024-07-30 22:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 11:08 [PATCH] selftests: user: remove user suite Muhammad Usama Anjum
2024-07-25 14:44 ` Shuah Khan
2024-07-26  8:16   ` Muhammad Usama Anjum
2024-07-26 17:19     ` Shuah Khan
2024-07-29  7:18       ` Muhammad Usama Anjum
2024-07-30 22:36   ` Shuah Khan [this message]
2024-07-31  2:33     ` Kees Cook
2024-07-31  5:13       ` Muhammad Usama Anjum
2024-07-31 18:12         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16f14d1a-56f2-4c2c-8180-74ad9bee0182@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=davidgow@google.com \
    --cc=kees@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=vitor@massaru.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox