Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: liujing <liujing@cmss.chinamobile.com>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c
Date: Fri, 7 Jun 2024 14:17:58 -0600	[thread overview]
Message-ID: <02ef91f7-9787-41be-82e7-b9403ce1046c@linuxfoundation.org> (raw)
In-Reply-To: <20231204090111.2967-1-liujing@cmss.chinamobile.com>

On 12/4/23 02:01, liujing wrote:
> in the main function of vdso_restorer.c,there is a dlopen function,
> but there is no dlclose function to close the file

Explain the change this patch is making in addition to describing
the problem. Also tell me how you found this problem.

> 
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
> ---
>   tools/testing/selftests/x86/vdso_restorer.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
> index fe99f2434155..a0b1155dee31 100644
> --- a/tools/testing/selftests/x86/vdso_restorer.c
> +++ b/tools/testing/selftests/x86/vdso_restorer.c
> @@ -57,6 +57,8 @@ int main()
>   		return 0;
>   	}
>   
> +	dlclose(vdso);
> +
>   	memset(&sa, 0, sizeof(sa));
>   	sa.handler = handler_with_siginfo;
>   	sa.flags = SA_SIGINFO;

thanks,
-- Shuah

      reply	other threads:[~2024-06-07 20:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04  9:01 [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c liujing
2024-06-07 20:17 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02ef91f7-9787-41be-82e7-b9403ce1046c@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liujing@cmss.chinamobile.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox