Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c
@ 2023-12-04  9:01 liujing
  2024-06-07 20:17 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2023-12-04  9:01 UTC (permalink / raw)
  To: shuah; +Cc: linux-kselftest, liujing

in the main function of vdso_restorer.c,there is a dlopen function,
but there is no dlclose function to close the file

Signed-off-by: liujing <liujing@cmss.chinamobile.com>
---
 tools/testing/selftests/x86/vdso_restorer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
index fe99f2434155..a0b1155dee31 100644
--- a/tools/testing/selftests/x86/vdso_restorer.c
+++ b/tools/testing/selftests/x86/vdso_restorer.c
@@ -57,6 +57,8 @@ int main()
 		return 0;
 	}
 
+	dlclose(vdso);
+
 	memset(&sa, 0, sizeof(sa));
 	sa.handler = handler_with_siginfo;
 	sa.flags = SA_SIGINFO;
-- 
2.18.2




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c
  2023-12-04  9:01 [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c liujing
@ 2024-06-07 20:17 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-06-07 20:17 UTC (permalink / raw)
  To: liujing, shuah; +Cc: linux-kselftest, Shuah Khan

On 12/4/23 02:01, liujing wrote:
> in the main function of vdso_restorer.c,there is a dlopen function,
> but there is no dlclose function to close the file

Explain the change this patch is making in addition to describing
the problem. Also tell me how you found this problem.

> 
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
> ---
>   tools/testing/selftests/x86/vdso_restorer.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/x86/vdso_restorer.c b/tools/testing/selftests/x86/vdso_restorer.c
> index fe99f2434155..a0b1155dee31 100644
> --- a/tools/testing/selftests/x86/vdso_restorer.c
> +++ b/tools/testing/selftests/x86/vdso_restorer.c
> @@ -57,6 +57,8 @@ int main()
>   		return 0;
>   	}
>   
> +	dlclose(vdso);
> +
>   	memset(&sa, 0, sizeof(sa));
>   	sa.handler = handler_with_siginfo;
>   	sa.flags = SA_SIGINFO;

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-07 20:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-04  9:01 [PATCH] tools/testing/selftests/x86: add dlclose function in the vdso_restorer.c liujing
2024-06-07 20:17 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox