Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
	petrm@nvidia.com, willemb@google.com,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: report output format as TAP 13 in Python tests
Date: Sat, 1 Mar 2025 11:52:06 +0100	[thread overview]
Message-ID: <0f196026-02ec-4db0-90b0-10c1e720c345@kernel.org> (raw)
In-Reply-To: <20250228180007.83325-1-kuba@kernel.org>

Hi Jakub,

On 28/02/2025 19:00, Jakub Kicinski wrote:
> The Python lib based tests report that they are producing
> "KTAP version 1", but really we aren't making use of any
> KTAP features, like subtests. Our output is plain TAP.
> 
> Report TAP 13 instead of KTAP 1, this is what mptcp tests do,

Indeed, and also TC tests, and all the ones using kselftest_harness.h I
think.

> and what NIPA knows how to parse best. For HW testing we need
> precise subtest result tracking.

I guess the best would be to have the kselftests infrastructure fully
supporting KTAP, and then have a way for each test to print subtests
correctly, not nested in the comments like it is done for the moment.
But that looks harder to put in place, and the current solution is used
in a few areas.

Good idea to switch to 'TAP version 13' for the moment, and re-use the
existing parsing in NIPA!

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2025-03-01 10:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 18:00 [PATCH net-next] selftests: net: report output format as TAP 13 in Python tests Jakub Kicinski
2025-03-01 10:52 ` Matthieu Baerts [this message]
2025-03-02 18:50   ` Jakub Kicinski
2025-03-03 23:36 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f196026-02ec-4db0-90b0-10c1e720c345@kernel.org \
    --to=matttbe@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox