[PATCH v3 06/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions

Linux Kernel Selftest development
 help / color / mirror / Atom feed

From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH v3 06/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Sat, 24 Feb 2018 14:31:18 +0900	[thread overview]
Message-ID: <151945027840.27508.3320829168318373572.stgit@devbox> (raw)
In-Reply-To: <151945010287.27508.6226184958678620828.stgit@devbox>

Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 kernel/trace/trace_probe.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 92d96ed6a2bf..0a809efabeb6 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
 	trace_seq_printf(s, fmt, *(type *)data);			\
 	return !trace_seq_has_overflowed(s);				\
 }									\
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;				\
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
 
 DEFINE_BASIC_PRINT_TYPE_FUNC(u8,  u8,  "%u")
 DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
 				 (const char *)get_loc_data(data, ent));
 	return !trace_seq_has_overflowed(s);
 }
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
 
 const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH v3 06/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Sat, 24 Feb 2018 14:31:18 +0900	[thread overview]
Message-ID: <151945027840.27508.3320829168318373572.stgit@devbox> (raw)
Message-ID: <20180224053118.-vYIkSdMFPJ9cItFOtc0xZ59ZvfjvUGeM7ahXk9tKXU@z> (raw)
In-Reply-To: <151945010287.27508.6226184958678620828.stgit@devbox>

Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 kernel/trace/trace_probe.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 92d96ed6a2bf..0a809efabeb6 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
 	trace_seq_printf(s, fmt, *(type *)data);			\
 	return !trace_seq_has_overflowed(s);				\
 }									\
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;				\
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
 
 DEFINE_BASIC_PRINT_TYPE_FUNC(u8,  u8,  "%u")
 DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
 				 (const char *)get_loc_data(data, ent));
 	return !trace_seq_has_overflowed(s);
 }
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
 
 const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2018-02-24  5:31 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24  5:28 [PATCH v3 00/18] tracing: probeevent: Improve fetcharg features mhiramat
2018-02-24  5:28 ` Masami Hiramatsu
2018-02-24  5:28 ` [PATCH v3 01/18] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol mhiramat
2018-02-24  5:28   ` Masami Hiramatsu
2018-02-26  0:38   ` namhyung
2018-02-26  0:38     ` Namhyung Kim
2018-02-27  5:23     ` mhiramat
2018-02-27  5:23       ` Masami Hiramatsu
2018-02-24  5:29 ` [PATCH v3 02/18] selftests: ftrace: Add probe event argument syntax testcase mhiramat
2018-02-24  5:29   ` Masami Hiramatsu
2018-02-24  5:29 ` [PATCH v3 03/18] selftests: ftrace: Add a testcase for string type with kprobe_event mhiramat
2018-02-24  5:29   ` Masami Hiramatsu
2018-02-24  5:30 ` [PATCH v3 04/18] tracing: probeevent: Cleanup print argument functions mhiramat
2018-02-24  5:30   ` Masami Hiramatsu
2018-02-24  5:30 ` [PATCH v3 05/18] tracing: probeevent: Cleanup argument field definition mhiramat
2018-02-24  5:30   ` Masami Hiramatsu
2018-02-24  5:31 ` mhiramat [this message]
2018-02-24  5:31   ` [PATCH v3 06/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-02-24  5:31 ` [PATCH v3 07/18] tracing: probeevent: Introduce new argument fetching code mhiramat
2018-02-24  5:31   ` Masami Hiramatsu
2018-02-24  5:32 ` [PATCH v3 08/18] tracing: probeevent: Unify fetch type tables mhiramat
2018-02-24  5:32   ` Masami Hiramatsu
2018-02-24  5:32 ` [PATCH v3 09/18] tracing: probeevent: Return consumed bytes of dynamic area mhiramat
2018-02-24  5:32   ` Masami Hiramatsu
2018-02-24  5:33 ` [PATCH v3 10/18] tracing: probeevent: Append traceprobe_ for exported function mhiramat
2018-02-24  5:33   ` Masami Hiramatsu
2018-02-24  5:33 ` [PATCH v3 11/18] tracing: probeevent: Unify fetch_insn processing common part mhiramat
2018-02-24  5:33   ` Masami Hiramatsu
2018-02-24  5:34 ` [PATCH v3 12/18] tracing: probeevent: Add symbol type mhiramat
2018-02-24  5:34   ` Masami Hiramatsu
2018-02-24  5:34 ` [PATCH v3 13/18] x86: ptrace: Add function argument access API mhiramat
2018-02-24  5:34   ` Masami Hiramatsu
2018-02-24  5:35 ` [PATCH v3 14/18] tracing: probeevent: Add $argN for accessing function args mhiramat
2018-02-24  5:35   ` Masami Hiramatsu
2018-02-24  5:35 ` [PATCH v3 15/18] tracing: probeevent: Add array type support mhiramat
2018-02-24  5:35   ` Masami Hiramatsu
2018-02-26  1:45   ` namhyung
2018-02-26  1:45     ` Namhyung Kim
2018-02-26 10:16     ` mhiramat
2018-02-26 10:16       ` Masami Hiramatsu
2018-02-24  5:36 ` [PATCH v3 16/18] selftests: ftrace: Add a testcase for symbol type mhiramat
2018-02-24  5:36   ` Masami Hiramatsu
2018-02-24  5:36 ` [PATCH v3 17/18] selftests: ftrace: Add a testcase for $argN with kprobe_event mhiramat
2018-02-24  5:36   ` Masami Hiramatsu
2018-02-24  5:37 ` [PATCH v3 18/18] selftests: ftrace: Add a testcase for array type " mhiramat
2018-02-24  5:37   ` Masami Hiramatsu

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:92d96ed6a2b dfblob:0a809efabeb dfblob:92d96ed6a2b
dfblob:0a809efabeb )
 OR (
bs:"[PATCH v3 06/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151945027840.27508.3320829168318373572.stgit@devbox \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox