From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH v4 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Wed, 28 Feb 2018 12:22:52 +0900 [thread overview]
Message-ID: <151978817231.2577.7346514119363309249.stgit@devbox> (raw)
In-Reply-To: <151978796240.2577.6531711990653677529.stgit@devbox>
Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.
Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
kernel/trace/trace_probe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 049e8531fdf8..51ca8f751332 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
trace_seq_printf(s, fmt, *(type *)data); \
return !trace_seq_has_overflowed(s); \
} \
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt; \
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
DEFINE_BASIC_PRINT_TYPE_FUNC(u8, u8, "%u")
DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
(const char *)get_loc_data(data, ent));
return !trace_seq_has_overflowed(s);
}
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH v4 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Wed, 28 Feb 2018 12:22:52 +0900 [thread overview]
Message-ID: <151978817231.2577.7346514119363309249.stgit@devbox> (raw)
Message-ID: <20180228032252.dxRPBWwEcNpVpQxmk2q56ntQonY81Eb9AqoCoE7hpeA@z> (raw)
In-Reply-To: <151978796240.2577.6531711990653677529.stgit@devbox>
Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.
Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
kernel/trace/trace_probe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 049e8531fdf8..51ca8f751332 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
trace_seq_printf(s, fmt, *(type *)data); \
return !trace_seq_has_overflowed(s); \
} \
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt; \
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
DEFINE_BASIC_PRINT_TYPE_FUNC(u8, u8, "%u")
DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
(const char *)get_loc_data(data, ent));
return !trace_seq_has_overflowed(s);
}
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-28 3:22 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:19 [PATCH v4 00/19] tracing: probeevent: Improve fetcharg features mhiramat
2018-02-28 3:19 ` Masami Hiramatsu
2018-02-28 3:19 ` [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol mhiramat
2018-02-28 3:19 ` Masami Hiramatsu
2018-03-02 4:49 ` namhyung
2018-03-02 4:49 ` Namhyung Kim
2018-03-02 6:32 ` mhiramat
2018-03-02 6:32 ` Masami Hiramatsu
2018-03-05 2:28 ` namhyung
2018-03-05 2:28 ` Namhyung Kim
2018-03-05 10:05 ` mhiramat
2018-03-05 10:05 ` Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 02/19] selftests: ftrace: Add probe event argument syntax testcase mhiramat
2018-02-28 3:20 ` Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 03/19] selftests: ftrace: Add a testcase for string type with kprobe_event mhiramat
2018-02-28 3:20 ` Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 04/19] selftests: ftrace: Add a testcase for probepoint mhiramat
2018-02-28 3:21 ` Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 05/19] tracing: probeevent: Cleanup print argument functions mhiramat
2018-02-28 3:21 ` Masami Hiramatsu
2018-02-28 3:22 ` [PATCH v4 06/19] tracing: probeevent: Cleanup argument field definition mhiramat
2018-02-28 3:22 ` Masami Hiramatsu
2018-02-28 3:22 ` mhiramat [this message]
2018-02-28 3:22 ` [PATCH v4 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 08/19] tracing: probeevent: Introduce new argument fetching code mhiramat
2018-02-28 3:23 ` Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 09/19] tracing: probeevent: Unify fetch type tables mhiramat
2018-02-28 3:23 ` Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 10/19] tracing: probeevent: Return consumed bytes of dynamic area mhiramat
2018-02-28 3:24 ` Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 11/19] tracing: probeevent: Append traceprobe_ for exported function mhiramat
2018-02-28 3:24 ` Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 12/19] tracing: probeevent: Unify fetch_insn processing common part mhiramat
2018-02-28 3:25 ` Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 13/19] tracing: probeevent: Add symbol type mhiramat
2018-02-28 3:25 ` Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 14/19] x86: ptrace: Add function argument access API mhiramat
2018-02-28 3:26 ` Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 15/19] tracing: probeevent: Add $argN for accessing function args mhiramat
2018-02-28 3:26 ` Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 16/19] tracing: probeevent: Add array type support mhiramat
2018-02-28 3:27 ` Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 17/19] selftests: ftrace: Add a testcase for symbol type mhiramat
2018-02-28 3:27 ` Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event mhiramat
2018-02-28 3:28 ` Masami Hiramatsu
2018-03-02 5:31 ` namhyung
2018-03-02 5:31 ` Namhyung Kim
2018-03-02 6:20 ` mhiramat
2018-03-02 6:20 ` Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 19/19] selftests: ftrace: Add a testcase for array type " mhiramat
2018-02-28 3:28 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151978817231.2577.7346514119363309249.stgit@devbox \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox