Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH selftests 1/2] selftests/ftrace: Make a script checkbashisms clean
Date: Fri, 22 Feb 2019 10:26:57 +0900	[thread overview]
Message-ID: <155079881689.5157.10494170079333363559.stgit@devbox> (raw)
In-Reply-To: <155079878723.5157.12433171255092403676.stgit@devbox>

Make kprobe_ftrace.tc checkbashisms clean. Since
"grep function available_tracers" causes an error
on checkbashisms, fix it by explicitly escaping
with double-quotations.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 .../ftrace/test.d/kprobe/kprobe_ftrace.tc          |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
index 492426e95e09..7650a82db3f5 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
@@ -3,7 +3,7 @@
 # description: Kprobe dynamic event with function tracer
 
 [ -f kprobe_events ] || exit_unsupported # this is configurable
-grep function available_tracers || exit_unsupported # this is configurable
+grep "function" available_tracers || exit_unsupported # this is configurable
 
 # prepare
 echo nop > current_tracer

WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH selftests 1/2] selftests/ftrace: Make a script checkbashisms clean
Date: Fri, 22 Feb 2019 10:26:57 +0900	[thread overview]
Message-ID: <155079881689.5157.10494170079333363559.stgit@devbox> (raw)
Message-ID: <20190222012657.5j3rv5_hXfG27SQBnsq-vP_QzS-pgIFdvoMXaBxNYbc@z> (raw)
In-Reply-To: <155079878723.5157.12433171255092403676.stgit@devbox>

Make kprobe_ftrace.tc checkbashisms clean. Since
"grep function available_tracers" causes an error
on checkbashisms, fix it by explicitly escaping
with double-quotations.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 .../ftrace/test.d/kprobe/kprobe_ftrace.tc          |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
index 492426e95e09..7650a82db3f5 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
@@ -3,7 +3,7 @@
 # description: Kprobe dynamic event with function tracer
 
 [ -f kprobe_events ] || exit_unsupported # this is configurable
-grep function available_tracers || exit_unsupported # this is configurable
+grep "function" available_tracers || exit_unsupported # this is configurable
 
 # prepare
 echo nop > current_tracer

  parent reply	other threads:[~2019-02-22  1:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  1:26 [PATCH selftests 0/2] Add checkbashisms meta-testcase mhiramat
2019-02-22  1:26 ` Masami Hiramatsu
2019-02-22  1:26 ` mhiramat [this message]
2019-02-22  1:26   ` [PATCH selftests 1/2] selftests/ftrace: Make a script checkbashisms clean Masami Hiramatsu
2019-02-22  1:27 ` [PATCH selftests 2/2] selftests/ftrace: Add checkbashisms meta-testcase mhiramat
2019-02-22  1:27   ` Masami Hiramatsu
2019-03-23 10:27 ` [PATCH selftests 0/2] " mhiramat
2019-03-23 10:27   ` Masami Hiramatsu
2019-05-24  2:31   ` rostedt
2019-05-24  2:31     ` Steven Rostedt
2019-05-24  3:02     ` shuah
2019-05-24  3:02       ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155079881689.5157.10494170079333363559.stgit@devbox \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox