* [PATCH] selftests: timers: remove unneeded semicolon
@ 2021-02-23 6:23 Jiapeng Chong
0 siblings, 0 replies; 9+ messages in thread
From: Jiapeng Chong @ 2021-02-23 6:23 UTC (permalink / raw)
To: john.stultz
Cc: tglx, sboyd, shuah, linux-kernel, linux-kselftest, Jiapeng Chong
Fix the following coccicheck warnings:
./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3: Unneeded
semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
tools/testing/selftests/timers/alarmtimer-suspend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
index 4da09db..54da4b08 100644
--- a/tools/testing/selftests/timers/alarmtimer-suspend.c
+++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
@@ -79,7 +79,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] selftests: timers: remove unneeded semicolon
@ 2021-03-15 8:07 Jiapeng Chong
2021-03-15 18:43 ` John Stultz
0 siblings, 1 reply; 9+ messages in thread
From: Jiapeng Chong @ 2021-03-15 8:07 UTC (permalink / raw)
To: john.stultz
Cc: tglx, sboyd, shuah, linux-kernel, linux-kselftest, Jiapeng Chong
Fix the following coccicheck warnings:
./tools/testing/selftests/timers/inconsistency-check.c:75:2-3: Unneeded
semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
tools/testing/selftests/timers/inconsistency-check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
index 022d3ff..e6756d9 100644
--- a/tools/testing/selftests/timers/inconsistency-check.c
+++ b/tools/testing/selftests/timers/inconsistency-check.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests: timers: remove unneeded semicolon
2021-03-15 8:07 [PATCH] selftests: timers: remove unneeded semicolon Jiapeng Chong
@ 2021-03-15 18:43 ` John Stultz
0 siblings, 0 replies; 9+ messages in thread
From: John Stultz @ 2021-03-15 18:43 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Thomas Gleixner, Stephen Boyd, Shuah Khan, lkml, linux-kselftest
On Mon, Mar 15, 2021 at 1:08 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/timers/inconsistency-check.c:75:2-3: Unneeded
> semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
No objection here. Thanks for sending this along.
Acked-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] selftests: timers: Remove unneeded semicolon
@ 2021-11-05 1:42 cgel.zte
0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2021-11-05 1:42 UTC (permalink / raw)
To: john.stultz
Cc: tglx, sboyd, shuah, linux-kernel, linux-kselftest, Zhang Mingyu,
Zeal Robot
From: Zhang Mingyu <zhang.mingyu@zte.com.cn>
Eliminate the following coccinelle check warning:
tools/testing/selftests/timers/inconsistency-check.c:75:2-3
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Zhang Mingyu <zhang.mingyu@zte.com.cn>
---
tools/testing/selftests/timers/inconsistency-check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
index 022d3ffe3fbf..e6756d9c60a7 100644
--- a/tools/testing/selftests/timers/inconsistency-check.c
+++ b/tools/testing/selftests/timers/inconsistency-check.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] selftests: timers: Remove unneeded semicolon
[not found] <20230614082010.28632-1-luojianhong@cdjrlc.com>
@ 2023-06-14 8:22 ` baomingtong001
0 siblings, 0 replies; 9+ messages in thread
From: baomingtong001 @ 2023-06-14 8:22 UTC (permalink / raw)
To: jstultz, tglx, sboyd, shuah; +Cc: linux-kernel, linux-kselftest
tools/testing/selftests/timers/nanosleep.c:75:2-3: Unneeded semicolon
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
tools/testing/selftests/timers/nanosleep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/nanosleep.c
b/tools/testing/selftests/timers/nanosleep.c
index df1d03516e7b..34e61507fa1f 100644
--- a/tools/testing/selftests/timers/nanosleep.c
+++ b/tools/testing/selftests/timers/nanosleep.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] selftests: timers: Remove unneeded semicolon
@ 2024-10-10 7:37 Chen Ni
2024-10-11 23:00 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: Chen Ni @ 2024-10-10 7:37 UTC (permalink / raw)
To: jstultz, tglx, sboyd, anna-maria, frederic, shuah
Cc: linux-kernel, linux-kselftest, Chen Ni
Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
tools/testing/selftests/timers/set-timer-lat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
index 5365e9ae61c3..7a1a2382538c 100644
--- a/tools/testing/selftests/timers/set-timer-lat.c
+++ b/tools/testing/selftests/timers/set-timer-lat.c
@@ -79,7 +79,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests: timers: Remove unneeded semicolon
2024-10-10 7:37 [PATCH] selftests: timers: Remove " Chen Ni
@ 2024-10-11 23:00 ` Shuah Khan
2024-10-12 0:47 ` John Stultz
0 siblings, 1 reply; 9+ messages in thread
From: Shuah Khan @ 2024-10-11 23:00 UTC (permalink / raw)
To: Chen Ni, jstultz, tglx, sboyd, anna-maria, frederic, shuah
Cc: linux-kernel, linux-kselftest, Shuah Khan
On 10/10/24 01:37, Chen Ni wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> tools/testing/selftests/timers/set-timer-lat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> index 5365e9ae61c3..7a1a2382538c 100644
> --- a/tools/testing/selftests/timers/set-timer-lat.c
> +++ b/tools/testing/selftests/timers/set-timer-lat.c
> @@ -79,7 +79,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }
>
Looks good to me.
John, I will apply this for next of you are okay with it.
Also I noticed clockstring() is defined in multiple tests.
Any thoughts on removing the duplicates and adding it to
a header file? This will add a dependency on another source
file, but might be good to remove the duplicate code.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests: timers: Remove unneeded semicolon
2024-10-11 23:00 ` Shuah Khan
@ 2024-10-12 0:47 ` John Stultz
2024-10-14 22:08 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: John Stultz @ 2024-10-12 0:47 UTC (permalink / raw)
To: Shuah Khan
Cc: Chen Ni, tglx, sboyd, anna-maria, frederic, shuah, linux-kernel,
linux-kselftest
On Fri, Oct 11, 2024 at 4:00 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 10/10/24 01:37, Chen Ni wrote:
> > Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> > semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > ---
> > tools/testing/selftests/timers/set-timer-lat.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> > index 5365e9ae61c3..7a1a2382538c 100644
> > --- a/tools/testing/selftests/timers/set-timer-lat.c
> > +++ b/tools/testing/selftests/timers/set-timer-lat.c
> > @@ -79,7 +79,7 @@ char *clockstring(int clockid)
> > return "CLOCK_BOOTTIME_ALARM";
> > case CLOCK_TAI:
> > return "CLOCK_TAI";
> > - };
> > + }
> > return "UNKNOWN_CLOCKID";
> > }
> >
>
> Looks good to me.
>
> John, I will apply this for next of you are okay with it.
Acked-by: John Stultz <jstultz@google.com>
> Also I noticed clockstring() is defined in multiple tests.
> Any thoughts on removing the duplicates and adding it to
> a header file? This will add a dependency on another source
> file, but might be good to remove the duplicate code.
Sure, no objections.
-john
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selftests: timers: Remove unneeded semicolon
2024-10-12 0:47 ` John Stultz
@ 2024-10-14 22:08 ` Shuah Khan
0 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2024-10-14 22:08 UTC (permalink / raw)
To: John Stultz
Cc: Chen Ni, tglx, sboyd, anna-maria, frederic, shuah, linux-kernel,
linux-kselftest, Shuah Khan
On 10/11/24 18:47, John Stultz wrote:
> On Fri, Oct 11, 2024 at 4:00 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> On 10/10/24 01:37, Chen Ni wrote:
>>> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
>>> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>>>
>>> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>>> ---
>>> tools/testing/selftests/timers/set-timer-lat.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
>>> index 5365e9ae61c3..7a1a2382538c 100644
>>> --- a/tools/testing/selftests/timers/set-timer-lat.c
>>> +++ b/tools/testing/selftests/timers/set-timer-lat.c
>>> @@ -79,7 +79,7 @@ char *clockstring(int clockid)
>>> return "CLOCK_BOOTTIME_ALARM";
>>> case CLOCK_TAI:
>>> return "CLOCK_TAI";
>>> - };
>>> + }
>>> return "UNKNOWN_CLOCKID";
>>> }
>>>
>>
>> Looks good to me.
>>
>> John, I will apply this for next of you are okay with it.
>
> Acked-by: John Stultz <jstultz@google.com>
Thank you. Applied linux-kselftest next for Linux 6.13-rc1.
>
>> Also I noticed clockstring() is defined in multiple tests.
>> Any thoughts on removing the duplicates and adding it to
>> a header file? This will add a dependency on another source
>> file, but might be good to remove the duplicate code.
>
> Sure, no objections.
Thanks. I will send patch in soon.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-10-14 22:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-15 8:07 [PATCH] selftests: timers: remove unneeded semicolon Jiapeng Chong
2021-03-15 18:43 ` John Stultz
-- strict thread matches above, loose matches on Subject: below --
2024-10-10 7:37 [PATCH] selftests: timers: Remove " Chen Ni
2024-10-11 23:00 ` Shuah Khan
2024-10-12 0:47 ` John Stultz
2024-10-14 22:08 ` Shuah Khan
[not found] <20230614082010.28632-1-luojianhong@cdjrlc.com>
2023-06-14 8:22 ` baomingtong001
2021-11-05 1:42 cgel.zte
2021-02-23 6:23 [PATCH] selftests: timers: remove " Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox