From: Paolo Abeni <pabeni@redhat.com>
To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com,
linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org,
dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com,
kuba@kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net,
liuhangbin@gmail.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Cc: Olivier Tilmans <olivier.tilmans@nokia.com>
Subject: Re: [PATCH v2 net-next 03/14] tcp: accecn: Add ece_delta to rate_sample
Date: Tue, 23 Sep 2025 11:47:44 +0200 [thread overview]
Message-ID: <161c09cc-9982-4046-9aa0-d0ec194daba0@redhat.com> (raw)
In-Reply-To: <20250918162133.111922-4-chia-yu.chang@nokia-bell-labs.com>
On 9/18/25 6:21 PM, chia-yu.chang@nokia-bell-labs.com wrote:
> From: Ilpo Järvinen <ij@kernel.org>
>
> Include echoed CE count into rate_sample. Replace local ecn_count
> variable with it.
Why? skimming over the next few patches it's not clear to me which is
the goal here.
Expanding the commit message would help, thanks!
Paolo
next prev parent reply other threads:[~2025-09-23 9:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 16:21 [PATCH v2 net-next 00/14] AccECN protocol case handling series chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 01/14] tcp: try to avoid safer when ACKs are thinned chia-yu.chang
2025-09-23 9:32 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 02/14] gro: flushing when CWR is set negatively affects AccECN chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 03/14] tcp: accecn: Add ece_delta to rate_sample chia-yu.chang
2025-09-23 9:47 ` Paolo Abeni [this message]
2025-09-25 7:40 ` Chia-Yu Chang (Nokia)
2025-09-25 7:44 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 04/14] tcp: L4S ECT(1) identifier and NEEDS_ACCECN for CC modules chia-yu.chang
2025-09-23 10:04 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 05/14] tcp: disable RFC3168 fallback identifier " chia-yu.chang
2025-09-23 10:08 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 06/14] tcp: accecn: handle unexpected AccECN negotiation feedback chia-yu.chang
2025-09-23 10:14 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 07/14] tcp: accecn: retransmit downgraded SYN in AccECN negotiation chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 08/14] tcp: move increment of num_retrans chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 09/14] tcp: accecn: retransmit SYN/ACK without AccECN option or non-AccECN SYN/ACK chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 10/14] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 11/14] tcp: accecn: fallback outgoing half link to non-AccECN chia-yu.chang
2025-09-23 10:28 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 12/14] tcp: accecn: verify ACE counter in 1st ACK after AccECN negotiation chia-yu.chang
2025-09-18 16:21 ` [PATCH v2 net-next 13/14] tcp: accecn: stop sending AccECN opt when loss ACK w/ option chia-yu.chang
2025-09-23 10:52 ` Paolo Abeni
2025-09-25 14:46 ` Chia-Yu Chang (Nokia)
2025-09-25 15:46 ` Paolo Abeni
2025-09-18 16:21 ` [PATCH v2 net-next 14/14] tcp: accecn: enable AccECN chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161c09cc-9982-4046-9aa0-d0ec194daba0@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia.com \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox