[PATCH] selftests: net: af_unix: Fix makefile to use TEST_GEN_PROGS

[PATCH] selftests: net: af_unix: Fix makefile to use TEST_GEN_PROGS

[Shuah Khan]

Makefile uses TEST_PROGS instead of TEST_GEN_PROGS to define
executables. TEST_PROGS is for shell scripts that need to be
installed and run by the common lib.mk framework. The common
framework doesn't touch TEST_PROGS when it does build and clean.

As a result "make kselftest-clean" and "make clean" fail to remove
executables. Run and install work because the common framework runs
and installs TEST_PROGS. Build works because the Makefile defines
"all" rule which is unnecessary if TEST_GEN_PROGS is used.

Use TEST_GEN_PROGS so the common framework can handle build/run/
install/clean properly.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
 tools/testing/selftests/net/af_unix/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/af_unix/Makefile b/tools/testing/selftests/net/af_unix/Makefile
index cfc7f4f97fd1..df341648f818 100644
--- a/tools/testing/selftests/net/af_unix/Makefile
+++ b/tools/testing/selftests/net/af_unix/Makefile
@@ -1,5 +1,2 @@
-##TEST_GEN_FILES := test_unix_oob
-TEST_PROGS := test_unix_oob
+TEST_GEN_PROGS := test_unix_oob
 include ../../lib.mk
-
-all: $(TEST_PROGS)
-- 
2.30.2

Re: [PATCH] selftests: net: af_unix: Fix makefile to use TEST_GEN_PROGS

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 17 Sep 2021 15:53:56 -0600 you wrote:
> Makefile uses TEST_PROGS instead of TEST_GEN_PROGS to define
> executables. TEST_PROGS is for shell scripts that need to be
> installed and run by the common lib.mk framework. The common
> framework doesn't touch TEST_PROGS when it does build and clean.
> 
> As a result "make kselftest-clean" and "make clean" fail to remove
> executables. Run and install work because the common framework runs
> and installs TEST_PROGS. Build works because the Makefile defines
> "all" rule which is unnecessary if TEST_GEN_PROGS is used.
> 
> [...]

Here is the summary with links:
  - selftests: net: af_unix: Fix makefile to use TEST_GEN_PROGS
    https://git.kernel.org/netdev/net/c/e30cd812dffa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html