* [PATCH] selftests/ftrace: Add required dependency for kprobe tests
@ 2024-06-12 22:12 Masami Hiramatsu (Google)
2024-08-14 0:53 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu (Google) @ 2024-06-12 22:12 UTC (permalink / raw)
To: Steven Rostedt, Shuah Khan
Cc: linux-kernel, linux-trace-kernel, mhiramat, linux-kselftest
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kprobe_args_{char,string}.tc are using available_filter_functions file
which is provided by function tracer. Thus if function tracer is disabled,
these tests are failed on recent kernels because tracefs_create_dir is
not raised events by adding a dynamic event.
Add available_filter_functions to requires line.
Fixes: 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
.../ftrace/test.d/kprobe/kprobe_args_char.tc | 2 +-
.../ftrace/test.d/kprobe/kprobe_args_string.tc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
index e21c9c27ece4..77f4c07cdcb8 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: Kprobe event char type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
case `uname -m` in
x86_64)
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
index 93217d459556..39001073f7ed 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
# description: Kprobe event string type argument
-# requires: kprobe_events
+# requires: kprobe_events available_filter_functions
case `uname -m` in
x86_64)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests
2024-06-12 22:12 [PATCH] selftests/ftrace: Add required dependency for kprobe tests Masami Hiramatsu (Google)
@ 2024-08-14 0:53 ` Masami Hiramatsu
2024-08-14 11:43 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Masami Hiramatsu @ 2024-08-14 0:53 UTC (permalink / raw)
To: Shuah Khan, Masami Hiramatsu (Google)
Cc: Steven Rostedt, Shuah Khan, linux-kernel, linux-trace-kernel,
linux-kselftest
Hi Shuah,
Can you pick this? I confirmed this can be applied on v6.11-rc3.
On Thu, 13 Jun 2024 07:12:10 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> kprobe_args_{char,string}.tc are using available_filter_functions file
> which is provided by function tracer. Thus if function tracer is disabled,
> these tests are failed on recent kernels because tracefs_create_dir is
> not raised events by adding a dynamic event.
> Add available_filter_functions to requires line.
>
> Fixes: 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> .../ftrace/test.d/kprobe/kprobe_args_char.tc | 2 +-
> .../ftrace/test.d/kprobe/kprobe_args_string.tc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
> index e21c9c27ece4..77f4c07cdcb8 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_char.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: Kprobe event char type argument
> -# requires: kprobe_events
> +# requires: kprobe_events available_filter_functions
>
> case `uname -m` in
> x86_64)
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 93217d459556..39001073f7ed 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: Kprobe event string type argument
> -# requires: kprobe_events
> +# requires: kprobe_events available_filter_functions
>
> case `uname -m` in
> x86_64)
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests
2024-08-14 0:53 ` Masami Hiramatsu
@ 2024-08-14 11:43 ` Shuah Khan
2024-08-14 15:45 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2024-08-14 11:43 UTC (permalink / raw)
To: Masami Hiramatsu (Google), Shuah Khan
Cc: Steven Rostedt, linux-kernel, linux-trace-kernel, linux-kselftest,
Shuah Khan
On 8/13/24 18:53, Masami Hiramatsu (Google) wrote:
> Hi Shuah,
>
> Can you pick this? I confirmed this can be applied on v6.11-rc3.
>
>
>
> On Thu, 13 Jun 2024 07:12:10 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
>> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>>
>> kprobe_args_{char,string}.tc are using available_filter_functions file
>> which is provided by function tracer. Thus if function tracer is disabled,
>> these tests are failed on recent kernels because tracefs_create_dir is
>> not raised events by adding a dynamic event.
>> Add available_filter_functions to requires line.
>>
>> Fixes: 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
>> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Applied to linux-kselftest next for Linux 6.12-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests
2024-08-14 11:43 ` Shuah Khan
@ 2024-08-14 15:45 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2024-08-14 15:45 UTC (permalink / raw)
To: Shuah Khan
Cc: Shuah Khan, Steven Rostedt, linux-kernel, linux-trace-kernel,
linux-kselftest
On Wed, 14 Aug 2024 05:43:29 -0600
Shuah Khan <skhan@linuxfoundation.org> wrote:
> On 8/13/24 18:53, Masami Hiramatsu (Google) wrote:
> > Hi Shuah,
> >
> > Can you pick this? I confirmed this can be applied on v6.11-rc3.
> >
> >
> >
> > On Thu, 13 Jun 2024 07:12:10 +0900
> > "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> >
> >> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >>
> >> kprobe_args_{char,string}.tc are using available_filter_functions file
> >> which is provided by function tracer. Thus if function tracer is disabled,
> >> these tests are failed on recent kernels because tracefs_create_dir is
> >> not raised events by adding a dynamic event.
> >> Add available_filter_functions to requires line.
> >>
> >> Fixes: 7c1130ea5cae ("test: ftrace: Fix kprobe test for eventfs")
> >> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Applied to linux-kselftest next for Linux 6.12-rc1
Thanks!
>
> thanks,
> -- Shuah
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-14 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-12 22:12 [PATCH] selftests/ftrace: Add required dependency for kprobe tests Masami Hiramatsu (Google)
2024-08-14 0:53 ` Masami Hiramatsu
2024-08-14 11:43 ` Shuah Khan
2024-08-14 15:45 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox