Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: forwarding: local_termination: Down ports on cleanup
@ 2024-08-26 17:15 Petr Machata
  2024-08-27 20:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Machata @ 2024-08-26 17:15 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	netdev
  Cc: Vladimir Oltean, linux-kselftest, Shuah Khan, Petr Machata

This test neglects to put ports down on cleanup. Fix it.

Fixes: 90b9566aa5cd ("selftests: forwarding: add a test for local_termination.sh")
Signed-off-by: Petr Machata <petrm@nvidia.com>
---
 tools/testing/selftests/net/forwarding/local_termination.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
index c5b0cbc85b3e..9b5a63519b94 100755
--- a/tools/testing/selftests/net/forwarding/local_termination.sh
+++ b/tools/testing/selftests/net/forwarding/local_termination.sh
@@ -278,6 +278,10 @@ bridge()
 cleanup()
 {
 	pre_cleanup
+
+	ip link set $h2 down
+	ip link set $h1 down
+
 	vrf_cleanup
 }
 
-- 
2.45.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] selftests: forwarding: local_termination: Down ports on cleanup
  2024-08-26 17:15 [PATCH net-next] selftests: forwarding: local_termination: Down ports on cleanup Petr Machata
@ 2024-08-27 20:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-27 20:00 UTC (permalink / raw)
  To: Petr Machata
  Cc: davem, edumazet, kuba, pabeni, netdev, vladimir.oltean,
	linux-kselftest, shuah

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 26 Aug 2024 19:15:11 +0200 you wrote:
> This test neglects to put ports down on cleanup. Fix it.
> 
> Fixes: 90b9566aa5cd ("selftests: forwarding: add a test for local_termination.sh")
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
>  tools/testing/selftests/net/forwarding/local_termination.sh | 4 ++++
>  1 file changed, 4 insertions(+)

Here is the summary with links:
  - [net-next] selftests: forwarding: local_termination: Down ports on cleanup
    https://git.kernel.org/netdev/net/c/65a3cce43d5b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-27 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 17:15 [PATCH net-next] selftests: forwarding: local_termination: Down ports on cleanup Petr Machata
2024-08-27 20:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox