* [PATCH bpf] selftests/bpf: add missing header include for htons
@ 2024-10-08 14:50 Alexis Lothoré (eBPF Foundation)
2024-10-08 18:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Alexis Lothoré (eBPF Foundation) @ 2024-10-08 14:50 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Eduard Zingerman, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Mykola Lysenko, Shuah Khan
Cc: ebpf, Thomas Petazzoni, bpf, linux-kselftest, linux-kernel,
Alexis Lothoré (eBPF Foundation)
Including the network_helpers.h header in tests can lead to the following
build error:
./network_helpers.h: In function ‘csum_tcpudp_magic’:
./network_helpers.h:116:14: error: implicit declaration of function \
‘htons’ [-Werror=implicit-function-declaration]
116 | s += htons(proto + len);
The error is avoided in many cases thanks to some other headers included
earlier and bringing in arpa/inet.h (ie: test_progs.h).
Make sure that test_progs build success does not depend on header ordering
by adding the missing header include in network_helpers.h
Fixes: f6642de0c3e9 ("selftests/bpf: Add csum helpers")
Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
---
tools/testing/selftests/bpf/network_helpers.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/network_helpers.h b/tools/testing/selftests/bpf/network_helpers.h
index c72c16e1aff825439896b38e59962ffafe92dc71..5764155b6d25188ed38e828e1e4a8a08f8a83934 100644
--- a/tools/testing/selftests/bpf/network_helpers.h
+++ b/tools/testing/selftests/bpf/network_helpers.h
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef __NETWORK_HELPERS_H
#define __NETWORK_HELPERS_H
+#include <arpa/inet.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <linux/types.h>
---
base-commit: 67a7c7b656cfc10a7280f71641fb9e88726e8a5d
change-id: 20241008-network_helpers_fix-bbb7d1589930
Best regards,
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH bpf] selftests/bpf: add missing header include for htons
2024-10-08 14:50 [PATCH bpf] selftests/bpf: add missing header include for htons Alexis Lothoré (eBPF Foundation)
@ 2024-10-08 18:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-08 18:00 UTC (permalink / raw)
To: =?utf-8?q?Alexis_Lothor=C3=A9_=28eBPF_Foundation=29_=3Calexis=2Elothore=40bo?=,
=?utf-8?q?otlin=2Ecom=3E?=
Cc: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, jolsa, mykolal, shuah, ebpf,
thomas.petazzoni, bpf, linux-kselftest, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (net)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Tue, 08 Oct 2024 16:50:57 +0200 you wrote:
> Including the network_helpers.h header in tests can lead to the following
> build error:
>
> ./network_helpers.h: In function ‘csum_tcpudp_magic’:
> ./network_helpers.h:116:14: error: implicit declaration of function \
> ‘htons’ [-Werror=implicit-function-declaration]
> 116 | s += htons(proto + len);
>
> [...]
Here is the summary with links:
- [bpf] selftests/bpf: add missing header include for htons
https://git.kernel.org/bpf/bpf-next/c/bc9b3fb827fc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-08 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 14:50 [PATCH bpf] selftests/bpf: add missing header include for htons Alexis Lothoré (eBPF Foundation)
2024-10-08 18:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox