From: Waiman Long <longman@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/5] cgroup/cpuset: Skip task update if hotplug doesn't affect current cpuset
Date: Tue, 14 Mar 2023 14:20:53 -0400 [thread overview]
Message-ID: <176a4cfd-2902-16a2-b9e7-cb66e1c5b49c@redhat.com> (raw)
In-Reply-To: <20230314165030.beu2ywtvqa3p45ta@blackpad>
On 3/14/23 12:50, Michal Koutný wrote:
> On Mon, Mar 06, 2023 at 03:08:45PM -0500, Waiman Long <longman@redhat.com> wrote:
>> If a hotplug event doesn't affect the current cpuset, there is no point
>> to call hotplug_update_tasks() or hotplug_update_tasks_legacy(). So
>> just skip it.
> This skips "insane" modification of cs->cpus_allowed in
> hotplug_update_tasks_legacy() but assuming cs->cpus_allowed is kept in
> sync with cs->effective_cpus on v1, it is OK to skip the update based
> only on effective_cpus check.
Yes, effective_cpus is equivalent to cpus_allowed in v1 unless you mount
the cpuset with the cpuset_v2_mode flag which will behave more like v2
where effective_cpus is still the key.
Cheers,
Longman
next prev parent reply other threads:[~2023-03-14 18:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 20:08 [PATCH 0/5] cgroup/cpuset: Miscellaneous updates Waiman Long
2023-03-06 20:08 ` [PATCH 1/5] cgroup/cpuset: Skip task update if hotplug doesn't affect current cpuset Waiman Long
2023-03-14 16:50 ` Michal Koutný
2023-03-14 18:20 ` Waiman Long [this message]
2023-03-06 20:08 ` [PATCH 2/5] cgroup/cpuset: Include offline CPUs when tasks' cpumasks in top_cpuset are updated Waiman Long
2023-03-14 17:34 ` Michal Koutný
2023-03-14 19:02 ` Waiman Long
2023-03-15 10:06 ` Michal Koutný
2023-03-15 14:39 ` Waiman Long
2023-03-06 20:08 ` [PATCH 3/5] cgroup/cpuset: Find another usable CPU if none found in current cpuset Waiman Long
2023-03-14 18:17 ` Michal Koutný
2023-03-14 20:22 ` Waiman Long
2023-03-17 12:27 ` Michal Koutný
2023-03-17 14:59 ` Waiman Long
2023-03-24 14:32 ` Will Deacon
2023-03-24 14:42 ` Waiman Long
2023-03-24 18:19 ` Michal Koutný
2023-03-25 22:08 ` Waiman Long
2023-03-06 20:08 ` [PATCH 4/5] cgroup/cpuset: Add CONFIG_DEBUG_CPUSETS config for cpuset testing Waiman Long
2023-03-06 20:08 ` [PATCH 5/5] cgroup/cpuset: Minor updates to test_cpuset_prs.sh Waiman Long
2023-03-07 16:16 ` Kamalesh Babulal
2023-03-15 16:24 ` [PATCH 0/5] cgroup/cpuset: Miscellaneous updates Will Deacon
2023-03-15 16:59 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176a4cfd-2902-16a2-b9e7-cb66e1c5b49c@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox