[PATCH net-next] selftests: net: Fix minor issues in cork_fragsize.py

[PATCH net-next] selftests: net: Fix minor issues in cork_fragsize.py

[Alice Mikityanska]

From: Alice Mikityanska <alice@isovalent.com>

return None is unreachable in check_kernel_config, because the try block
always returns a True or False value, and the except block continues the
loop. The return None was supposed to be outside the for loop, to make
pylint happy by making all the flows of the function return a value
explicitly.

While at it, make the docstring of check_dmesg_clean clearer by
explaining the return values.

Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260901195714.673548-1-alice.kernel%40fastmail.im
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
---
 tools/testing/selftests/net/cork_fragsize.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/cork_fragsize.py b/tools/testing/selftests/net/cork_fragsize.py
index 7afd643d07ec..ae6be804b7a2 100755
--- a/tools/testing/selftests/net/cork_fragsize.py
+++ b/tools/testing/selftests/net/cork_fragsize.py
@@ -54,7 +54,7 @@ def check_kernel_config(option: str) -> bool | None:
                 return False
         except OSError:
             continue
-        return None
+    return None
 
 
 def assert_debug_kernel() -> None:
@@ -71,7 +71,8 @@ def assert_debug_kernel() -> None:
 
 def check_dmesg_clean(func: str) -> bool:
     '''
-    Check if the given function produced a WARN in dmesg.
+    Check if the given function produced a WARN in dmesg. Returns True if dmesg
+    is clean, i.e. doesn't contain traces of a WARNING in the given function.
     '''
 
     with subprocess.Popen(['dmesg'], stdout=subprocess.PIPE) as dmesg:
-- 
2.55.0

Re: [PATCH net-next] selftests: net: Fix minor issues in cork_fragsize.py

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  1 Oct 2026 15:42:01 +0300 you wrote:
> From: Alice Mikityanska <alice@isovalent.com>
> 
> return None is unreachable in check_kernel_config, because the try block
> always returns a True or False value, and the except block continues the
> loop. The return None was supposed to be outside the for loop, to make
> pylint happy by making all the flows of the function return a value
> explicitly.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: net: Fix minor issues in cork_fragsize.py
    https://git.kernel.org/netdev/net-next/c/363cf8def362

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html