Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: salyzyn at android.com (Mark Salyzyn)
Subject: [PATCH v6 17/19] mips: Add support for generic vDSO
Date: Mon, 3 Jun 2019 07:54:24 -0700	[thread overview]
Message-ID: <200c39f5-3bff-cacb-57c9-e11c57df70f5@android.com> (raw)
In-Reply-To: <CAK8P3a29QXCP8nw7po06GeYEGvJ_y2GxjAvswFk3=Y6YCjbdDg@mail.gmail.com>

On 05/31/2019 01:34 AM, Arnd Bergmann wrote:
> On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino
> <vincenzo.frascino at arm.com> wrote:
>
>> --- a/arch/mips/vdso/vdso.lds.S
>> +++ b/arch/mips/vdso/vdso.lds.S
>> @@ -99,6 +99,10 @@ VERSION
>>          global:
>>                  __vdso_clock_gettime;
>>                  __vdso_gettimeofday;
>> +               __vdso_clock_getres;
>> +#if _MIPS_SIM != _MIPS_SIM_ABI64
>> +               __vdso_clock_gettime64;
>> +#endif
>>   #endif
>>          local: *;
>>          };
> Same comment as for the corresponding arm change: I'd leave the ABI
> changes to a separate patch, and probably not add __vdso_clock_getres
> at all.

Removing this would break ABI (would it really, it just replaces the 
syscall ... so it is more of a user space expectation)? already present 
in arm64 before this series.

-- Mark

WARNING: multiple messages have this Message-ID (diff)
From: salyzyn@android.com (Mark Salyzyn)
Subject: [PATCH v6 17/19] mips: Add support for generic vDSO
Date: Mon, 3 Jun 2019 07:54:24 -0700	[thread overview]
Message-ID: <200c39f5-3bff-cacb-57c9-e11c57df70f5@android.com> (raw)
Message-ID: <20190603145424.6XOdDxTMCPyxn3GyB_Y1A6mCfjDyXhOq_xKKpfX-HDw@z> (raw)
In-Reply-To: <CAK8P3a29QXCP8nw7po06GeYEGvJ_y2GxjAvswFk3=Y6YCjbdDg@mail.gmail.com>

On 05/31/2019 01:34 AM, Arnd Bergmann wrote:
> On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino
> <vincenzo.frascino@arm.com> wrote:
>
>> --- a/arch/mips/vdso/vdso.lds.S
>> +++ b/arch/mips/vdso/vdso.lds.S
>> @@ -99,6 +99,10 @@ VERSION
>>          global:
>>                  __vdso_clock_gettime;
>>                  __vdso_gettimeofday;
>> +               __vdso_clock_getres;
>> +#if _MIPS_SIM != _MIPS_SIM_ABI64
>> +               __vdso_clock_gettime64;
>> +#endif
>>   #endif
>>          local: *;
>>          };
> Same comment as for the corresponding arm change: I'd leave the ABI
> changes to a separate patch, and probably not add __vdso_clock_getres
> at all.

Removing this would break ABI (would it really, it just replaces the 
syscall ... so it is more of a user space expectation)? already present 
in arm64 before this series.

-- Mark

  parent reply	other threads:[~2019-06-03 14:54 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 14:15 [PATCH v6 00/19] Unify vDSOs across more architectures vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 01/19] kernel: Standardize vdso_datapage vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-31  8:16   ` arnd
2019-05-31  8:16     ` Arnd Bergmann
2019-06-04 12:05     ` vincenzo.frascino
2019-06-04 12:05       ` Vincenzo Frascino
2019-06-10 17:47       ` huw
2019-06-10 17:47         ` Huw Davies
2019-06-10 17:47         ` Huw Davies
2019-06-10  9:27   ` huw
2019-06-10  9:27     ` Huw Davies
2019-06-10  9:27     ` Huw Davies
2019-06-10 10:17     ` vincenzo.frascino
2019-06-10 10:17       ` Vincenzo Frascino
2019-06-10 10:17       ` Vincenzo Frascino
2019-06-10 10:31       ` huw
2019-06-10 10:31         ` Huw Davies
2019-06-10 10:31         ` Huw Davies
2019-06-10 11:07         ` vincenzo.frascino
2019-06-10 11:07           ` Vincenzo Frascino
2019-06-10 11:07           ` Vincenzo Frascino
2019-06-10 11:37           ` huw
2019-06-10 11:37             ` Huw Davies
2019-06-10 11:37             ` Huw Davies
2019-05-30 14:15 ` [PATCH v6 02/19] kernel: Define gettimeofday vdso common code vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-31  8:19   ` arnd
2019-05-31  8:19     ` Arnd Bergmann
2019-06-04 12:08     ` vincenzo.frascino
2019-06-04 12:08       ` Vincenzo Frascino
2019-06-10  9:31   ` huw
2019-06-10  9:31     ` Huw Davies
2019-06-10  9:31     ` Huw Davies
2019-06-10 10:18     ` vincenzo.frascino
2019-06-10 10:18       ` Vincenzo Frascino
2019-06-10 10:18       ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 03/19] kernel: Unify update_vsyscall implementation vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-06-10  9:34   ` huw
2019-06-10  9:34     ` Huw Davies
2019-06-10  9:34     ` Huw Davies
2019-06-10 10:19     ` vincenzo.frascino
2019-06-10 10:19       ` Vincenzo Frascino
2019-06-10 10:19       ` Vincenzo Frascino
2019-06-14 11:10   ` Thomas Gleixner
2019-06-14 12:15     ` Vincenzo Frascino
2019-06-14 12:19       ` Thomas Gleixner
2019-06-14 12:25         ` Vincenzo Frascino
2019-06-14 13:07           ` Thomas Gleixner
2019-05-30 14:15 ` [PATCH v6 04/19] arm64: Substitute gettimeofday with C implementation vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 05/19] arm64: Build vDSO with -ffixed-x18 vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 06/19] arm64: compat: Add missing syscall numbers vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 07/19] arm64: compat: Expose signal related structures vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 08/19] arm64: compat: Generate asm offsets for signals vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 09/19] lib: vdso: Add compat support vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 10/19] arm64: compat: Add vDSO vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 11/19] arm64: Refactor vDSO code vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 12/19] arm64: compat: vDSO setup for compat layer vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 13/19] arm64: elf: vDSO code page discovery vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 14/19] arm64: compat: Get sigreturn trampolines from vDSO vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 15/19] arm64: Add vDSO compat support vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-06-01  9:38   ` catalin.marinas
2019-06-01  9:38     ` Catalin Marinas
2019-06-04 12:10     ` vincenzo.frascino
2019-06-04 12:10       ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 16/19] arm: Add support for generic vDSO vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-31  8:32   ` arnd
2019-05-31  8:32     ` Arnd Bergmann
2019-05-30 14:15 ` [PATCH v6 17/19] mips: " vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-31  8:34   ` arnd
2019-05-31  8:34     ` Arnd Bergmann
2019-06-03 14:54     ` salyzyn [this message]
2019-06-03 14:54       ` Mark Salyzyn
2019-06-03 17:07       ` arnd
2019-06-03 17:07         ` Arnd Bergmann
2019-05-30 14:15 ` [PATCH v6 18/19] x86: " vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-30 15:41   ` mikelley
2019-05-30 15:41     ` Michael Kelley
2019-06-04 12:13     ` vincenzo.frascino
2019-06-04 12:13       ` Vincenzo Frascino
2019-06-14 11:15     ` Thomas Gleixner
2019-06-14 21:17       ` Sasha Levin
2019-06-22 14:46         ` Thomas Gleixner
2019-06-23 19:09           ` Sasha Levin
2019-06-23 21:58             ` Stephen Rothwell
2019-06-24  0:24               ` Sasha Levin
2019-06-24  1:20                 ` Stephen Rothwell
2019-06-23 22:12             ` Thomas Gleixner
2019-06-24  0:04               ` Michael Kelley
2019-06-24  0:25                 ` Thomas Gleixner
2019-06-28 18:40                   ` Michael Kelley
2019-05-30 14:15 ` [PATCH v6 19/19] kselftest: Extend vDSO selftest vincenzo.frascino
2019-05-30 14:15   ` Vincenzo Frascino
2019-05-31  8:53   ` arnd
2019-05-31  8:53     ` Arnd Bergmann
2019-05-31  8:46 ` [PATCH v6 00/19] Unify vDSOs across more architectures arnd
2019-05-31  8:46   ` Arnd Bergmann
2019-06-04 12:04   ` vincenzo.frascino
2019-06-04 12:04     ` Vincenzo Frascino
2019-06-04 12:12     ` arnd
2019-06-04 12:12       ` Arnd Bergmann
2019-06-05 14:32       ` vincenzo.frascino
2019-06-05 14:32         ` Vincenzo Frascino
2019-06-14 12:16     ` Thomas Gleixner
2019-06-14 12:19       ` Vincenzo Frascino
2019-06-20  6:17 ` Shijith Thotton
2019-06-20  8:55   ` Vincenzo Frascino
2019-06-20 16:27 ` Andre Przywara
2019-06-21  9:11   ` Vincenzo Frascino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200c39f5-3bff-cacb-57c9-e11c57df70f5@android.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox