From: dan.carpenter at oracle.com (Dan Carpenter)
Subject: [RFC v4 08/17] kunit: test: add support for test abort
Date: Thu, 28 Feb 2019 16:54:03 +0300 [thread overview]
Message-ID: <20190228135403.GD9806@kadam> (raw)
In-Reply-To: <CAFd5g46QCisA4PHQXo57-LC6sNdk=OUjBE0O1s4005uBz_Vo6Q@mail.gmail.com>
On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote:
> you could do:
>
> if (IS_ERR_OR_NULL(ptr)) {
> KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr);
> return;
> }
It's best to not mix error pointers and NULL but when we do mix them,
it means that NULL is a special kind of success. Like we try to load
a feature and we get back:
valid pointer <-- success
null <-- feature is disabled. not an error.
error pointer <-- feature is broken. fail.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
Subject: [RFC v4 08/17] kunit: test: add support for test abort
Date: Thu, 28 Feb 2019 16:54:03 +0300 [thread overview]
Message-ID: <20190228135403.GD9806@kadam> (raw)
Message-ID: <20190228135403.SsJI4pFV4mYo4jfBl1a58O25OgW8tdfVMeREhZ0Ed6w@z> (raw)
In-Reply-To: <CAFd5g46QCisA4PHQXo57-LC6sNdk=OUjBE0O1s4005uBz_Vo6Q@mail.gmail.com>
On Thu, Feb 28, 2019@01:03:24AM -0800, Brendan Higgins wrote:
> you could do:
>
> if (IS_ERR_OR_NULL(ptr)) {
> KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr);
> return;
> }
It's best to not mix error pointers and NULL but when we do mix them,
it means that NULL is a special kind of success. Like we try to load
a feature and we get back:
valid pointer <-- success
null <-- feature is disabled. not an error.
error pointer <-- feature is broken. fail.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-28 13:54 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 21:37 [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 01/17] kunit: test: add KUnit test runner core brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 02/17] kunit: test: add test resource management API brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-15 21:01 ` sboyd
2019-02-15 21:01 ` Stephen Boyd
2019-02-19 23:24 ` brendanhiggins
2019-02-19 23:24 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 03/17] kunit: test: add string_stream a std::stream like string builder brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 04/17] kunit: test: add test_stream a std::stream like logger brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 05/17] kunit: test: add the concept of expectations brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 06/17] kbuild: enable building KUnit brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 07/17] kunit: test: add initial tests brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 08/17] kunit: test: add support for test abort brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-18 19:52 ` frowand.list
2019-02-18 19:52 ` Frank Rowand
2019-02-20 3:39 ` brendanhiggins
2019-02-20 3:39 ` Brendan Higgins
2019-02-20 6:44 ` frowand.list
2019-02-20 6:44 ` Frank Rowand
2019-02-28 7:42 ` brendanhiggins
2019-02-28 7:42 ` Brendan Higgins
2019-03-22 1:09 ` frowand.list
2019-03-22 1:09 ` Frank Rowand
2019-03-22 1:41 ` brendanhiggins
2019-03-22 1:41 ` Brendan Higgins
2019-03-22 7:10 ` knut.omang
2019-03-22 7:10 ` Knut Omang
2019-03-25 22:32 ` brendanhiggins
2019-03-25 22:32 ` Brendan Higgins
2019-03-26 7:44 ` knut.omang
2019-03-26 7:44 ` Knut Omang
2019-02-26 20:35 ` sboyd
2019-02-26 20:35 ` Stephen Boyd
2019-02-28 9:03 ` brendanhiggins
2019-02-28 9:03 ` Brendan Higgins
2019-02-28 13:54 ` dan.carpenter [this message]
2019-02-28 13:54 ` Dan Carpenter
2019-03-04 22:28 ` brendanhiggins
2019-03-04 22:28 ` Brendan Higgins
[not found] ` <155137694423.260864.2846034318906225490@swboyd.mtv.corp.google.com>
2019-03-04 22:39 ` brendanhiggins
2019-03-04 22:39 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 09/17] kunit: test: add the concept of assertions brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 10/17] kunit: test: add test managed resource tests brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-15 20:54 ` sboyd
2019-02-15 20:54 ` Stephen Boyd
2019-02-19 23:20 ` brendanhiggins
2019-02-19 23:20 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 11/17] kunit: tool: add Python wrappers for running KUnit tests brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 12/17] kunit: defconfig: add defconfigs for building " brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 13/17] Documentation: kunit: add documentation for KUnit brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 14/17] MAINTAINERS: add entry for KUnit the unit testing framework brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 15/17] of: unittest: migrate tests to run on KUnit brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-02-16 0:24 ` frowand.list
2019-02-16 0:24 ` Frank Rowand
2019-02-20 2:24 ` brendanhiggins
2019-02-20 2:24 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 16/17] of: unittest: split out a couple of test cases from unittest brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-03-22 1:14 ` frowand.list
2019-03-22 1:14 ` Frank Rowand
2019-03-22 1:45 ` brendanhiggins
2019-03-22 1:45 ` Brendan Higgins
2019-02-14 21:37 ` [RFC v4 17/17] of: unittest: split up some super large test cases brendanhiggins
2019-02-14 21:37 ` Brendan Higgins
2019-03-22 1:16 ` frowand.list
2019-03-22 1:16 ` Frank Rowand
2019-03-22 1:45 ` brendanhiggins
2019-03-22 1:45 ` Brendan Higgins
2019-02-18 20:02 ` [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework frowand.list
2019-02-18 20:02 ` Frank Rowand
2019-02-20 6:34 ` brendanhiggins
2019-02-20 6:34 ` Brendan Higgins
2019-02-20 6:46 ` frowand.list
2019-02-20 6:46 ` Frank Rowand
2019-02-22 20:52 ` bauerman
2019-02-22 20:52 ` Thiago Jung Bauermann
2019-02-28 4:18 ` brendanhiggins
2019-02-28 4:18 ` Brendan Higgins
2019-02-28 4:15 ` brendanhiggins
2019-02-28 4:15 ` Brendan Higgins
2019-03-04 23:01 ` brendanhiggins
2019-03-04 23:01 ` Brendan Higgins
2019-03-22 1:23 ` frowand.list
2019-03-22 1:23 ` Frank Rowand
2019-03-25 22:11 ` brendanhiggins
2019-03-25 22:11 ` Brendan Higgins
2019-03-21 1:07 ` logang
2019-03-21 1:07 ` Logan Gunthorpe
2019-03-21 5:23 ` knut.omang
2019-03-21 5:23 ` Knut Omang
2019-03-21 15:56 ` logang
2019-03-21 15:56 ` Logan Gunthorpe
2019-03-21 16:55 ` brendanhiggins
2019-03-21 16:55 ` Brendan Higgins
2019-03-21 19:13 ` knut.omang
2019-03-21 19:13 ` Knut Omang
2019-03-21 19:29 ` logang
2019-03-21 19:29 ` Logan Gunthorpe
2019-03-21 20:14 ` knut.omang
2019-03-21 20:14 ` Knut Omang
2019-03-21 22:07 ` brendanhiggins
2019-03-21 22:07 ` Brendan Higgins
2019-03-21 22:26 ` logang
2019-03-21 22:26 ` Logan Gunthorpe
2019-03-21 23:33 ` brendanhiggins
2019-03-21 23:33 ` Brendan Higgins
2019-03-22 1:12 ` frowand.list
2019-03-22 1:12 ` Frank Rowand
2019-03-25 22:12 ` brendanhiggins
2019-03-25 22:12 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228135403.GD9806@kadam \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox