From: brendanhiggins at google.com (Brendan Higgins)
Subject: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
WARNING: multiple messages have this Message-ID (diff)
From: brendanhiggins@google.com (Brendan Higgins)
Subject: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
Message-ID: <20190514181233.VZOU4qMlVkndFSBaoMhtLSrz5SMZzTKCnfVrnx1H-7M@z> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019@10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019@01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019@08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019@10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
next prev parent reply other threads:[~2019-05-14 18:12 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 5:42 [PATCH v3 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 01/18] kunit: test: add KUnit test runner core brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 02/18] kunit: test: add test resource management API brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 03/18] kunit: test: add string_stream a std::stream like string builder brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 04/18] kunit: test: add kunit_stream a std::stream like logger brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 05/18] kunit: test: add the concept of expectations brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 06/18] kbuild: enable building KUnit brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 07/18] kunit: test: add initial tests brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 6:56 ` peterz
2019-05-14 6:56 ` Peter Zijlstra
2019-05-14 8:12 ` brendanhiggins
2019-05-14 8:12 ` Brendan Higgins
2019-05-14 8:46 ` peterz
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 18:12 ` brendanhiggins [this message]
2019-05-14 18:12 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 09/18] kunit: test: add support for test abort brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 10/18] kunit: test: add tests for kunit " brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 11/18] kunit: test: add the concept of assertions brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 12/18] kunit: test: add tests for KUnit managed resources brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 13/18] kunit: tool: add Python wrappers for running KUnit tests brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 14/18] kunit: defconfig: add defconfigs for building " brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 15/18] Documentation: kunit: add documentation for KUnit brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 13:34 ` corbet
2019-05-14 13:34 ` Jonathan Corbet
2019-05-14 18:08 ` brendanhiggins
2019-05-14 18:08 ` Brendan Higgins
2019-05-14 18:16 ` corbet
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 23:19 ` brendanhiggins
2019-05-14 23:19 ` Brendan Higgins
2019-05-15 13:45 ` corbet
2019-05-15 13:45 ` Jonathan Corbet
2019-05-14 5:42 ` [PATCH v3 16/18] MAINTAINERS: add entry for KUnit the unit testing framework brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514181233.GB109557@google.com \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox