Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: logang at deltatee.com (Logan Gunthorpe)
Subject: [PATCH v5 05/10] NTB: Rename ntb.c to support multiple source files in the module
Date: Thu, 23 May 2019 16:30:55 -0600	[thread overview]
Message-ID: <20190523223100.5526-6-logang@deltatee.com> (raw)
In-Reply-To: <20190523223100.5526-1-logang@deltatee.com>

The kbuild system does not support having multiple source files in
a module if one of those source files has the same name as the module.

Therefore, we must rename ntb.c to core.c, while the module remains
ntb.ko.

This is similar to the way the nvme modules are structured.

Signed-off-by: Logan Gunthorpe <logang at deltatee.com>
Cc: Jon Mason <jdmason at kudzu.us>
Cc: Dave Jiang <dave.jiang at intel.com>
Cc: Allen Hubbe <allenbh at gmail.com>
---
 drivers/ntb/Makefile          | 2 ++
 drivers/ntb/{ntb.c => core.c} | 0
 2 files changed, 2 insertions(+)
 rename drivers/ntb/{ntb.c => core.c} (100%)

diff --git a/drivers/ntb/Makefile b/drivers/ntb/Makefile
index 1921dec1949d..537226f8e78d 100644
--- a/drivers/ntb/Makefile
+++ b/drivers/ntb/Makefile
@@ -1,2 +1,4 @@
 obj-$(CONFIG_NTB) += ntb.o hw/ test/
 obj-$(CONFIG_NTB_TRANSPORT) += ntb_transport.o
+
+ntb-y := core.o
diff --git a/drivers/ntb/ntb.c b/drivers/ntb/core.c
similarity index 100%
rename from drivers/ntb/ntb.c
rename to drivers/ntb/core.c
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: logang@deltatee.com (Logan Gunthorpe)
Subject: [PATCH v5 05/10] NTB: Rename ntb.c to support multiple source files in the module
Date: Thu, 23 May 2019 16:30:55 -0600	[thread overview]
Message-ID: <20190523223100.5526-6-logang@deltatee.com> (raw)
Message-ID: <20190523223055.ZNcg8gwYqw6o-sZSRxCVge2rGJu-1buoZDY1ftit6gc@z> (raw)
In-Reply-To: <20190523223100.5526-1-logang@deltatee.com>

The kbuild system does not support having multiple source files in
a module if one of those source files has the same name as the module.

Therefore, we must rename ntb.c to core.c, while the module remains
ntb.ko.

This is similar to the way the nvme modules are structured.

Signed-off-by: Logan Gunthorpe <logang at deltatee.com>
Cc: Jon Mason <jdmason at kudzu.us>
Cc: Dave Jiang <dave.jiang at intel.com>
Cc: Allen Hubbe <allenbh at gmail.com>
---
 drivers/ntb/Makefile          | 2 ++
 drivers/ntb/{ntb.c => core.c} | 0
 2 files changed, 2 insertions(+)
 rename drivers/ntb/{ntb.c => core.c} (100%)

diff --git a/drivers/ntb/Makefile b/drivers/ntb/Makefile
index 1921dec1949d..537226f8e78d 100644
--- a/drivers/ntb/Makefile
+++ b/drivers/ntb/Makefile
@@ -1,2 +1,4 @@
 obj-$(CONFIG_NTB) += ntb.o hw/ test/
 obj-$(CONFIG_NTB_TRANSPORT) += ntb_transport.o
+
+ntb-y := core.o
diff --git a/drivers/ntb/ntb.c b/drivers/ntb/core.c
similarity index 100%
rename from drivers/ntb/ntb.c
rename to drivers/ntb/core.c
-- 
2.20.1

  parent reply	other threads:[~2019-05-23 22:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 22:30 [PATCH v5 00/10] Support using MSI interrupts in ntb_transport logang
2019-05-23 22:30 ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 01/10] PCI/MSI: Support allocating virtual MSI interrupts logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 02/10] PCI/switchtec: Add module parameter to request more interrupts logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 03/10] NTB: Introduce helper functions to calculate logical port number logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 04/10] NTB: Introduce functions to calculate multi-port resource index logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` logang [this message]
2019-05-23 22:30   ` [PATCH v5 05/10] NTB: Rename ntb.c to support multiple source files in the module Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 06/10] NTB: Introduce MSI library logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 07/10] NTB: Introduce NTB MSI Test Client logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 08/10] NTB: Add ntb_msi_test support to ntb_test logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:30 ` [PATCH v5 09/10] NTB: Add MSI interrupt support to ntb_transport logang
2019-05-23 22:30   ` Logan Gunthorpe
2019-05-23 22:31 ` [PATCH v5 10/10] NTB: Describe the ntb_msi_test client in the documentation logang
2019-05-23 22:31   ` Logan Gunthorpe
2019-06-13 13:30 ` [PATCH v5 00/10] Support using MSI interrupts in ntb_transport Jon Mason
2019-06-13 15:46   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523223100.5526-6-logang@deltatee.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox