From: Kees Cook <keescook@chromium.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/exec: Fix building of exec test
Date: Wed, 4 Nov 2020 11:07:16 -0800 [thread overview]
Message-ID: <202011041105.5A2D9D1F@keescook> (raw)
In-Reply-To: <20201104100706.659089-1-mpe@ellerman.id.au>
On Wed, Nov 04, 2020 at 09:07:06PM +1100, Michael Ellerman wrote:
> Currently the exec test does not build:
>
> make[1]: Entering directory '/linux/tools/testing/selftests/exec'
> ...
> make[1]: *** No rule to make target '/output/kselftest/exec/pipe', needed by 'all'.
>
> This is because pipe is listed in TEST_GEN_FILES, but pipe is not
> generated by the Makefile, it's created at runtime. So drop pipe from
> TEST_GEN_FILES.
Ah, yes, shouldn't it be added to EXTRA_CLEAN though?
Fixes: 61016db15b8e ("selftests/exec: Verify execve of non-regular files fail")
>
> With that fixed, then install fails:
>
> make[1]: Entering directory '/linux/tools/testing/selftests/exec'
> rsync -a binfmt_script non-regular /output/install/exec/
> rsync: link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2)
>
> That's because non-regular hasn't been built, because it's in
> TEST_PROGS, it should be part of TEST_GEN_PROGS to indicate that it
> needs to be built.
Yes, thanks again!
Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests")
for both:
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
prev parent reply other threads:[~2020-11-04 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:07 [PATCH] selftests/exec: Fix building of exec test Michael Ellerman
2020-11-04 19:07 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011041105.5A2D9D1F@keescook \
--to=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox