[PATCH AUTOSEL 4.19 09/13] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

[PATCH AUTOSEL 4.19 09/13] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

[Sasha Levin]

From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

[ Upstream commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 ]

The PREEMPT_RT patchset does not use do_softirq() function thus trying
to filter for do_softirq fails for such kernel:

  echo do_softirq
  ftracetest: 81: echo: echo: I/O error

Choose some other visible function for the test.  The function does not
have to be actually executed during the test, because it is only testing
filter API interface.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
index 68e7a48f5828e..412e5c1f13ca6 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
@@ -33,7 +33,7 @@ do_reset
 
 FILTER=set_ftrace_filter
 FUNC1="schedule"
-FUNC2="do_softirq"
+FUNC2="scheduler_tick"
 
 ALL_FUNCS="#### all functions enabled ####"
 
-- 
2.34.1

Re: [PATCH AUTOSEL 4.19 09/13] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On Tue 2022-02-22 21:31:48, Sasha Levin wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> [ Upstream commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 ]
> 
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
> 
>   echo do_softirq
>   ftracetest: 81: echo: echo: I/O error
> 
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.

This needs -rt patch even on mainline, right?

It is certainly not needed in -stable branches.

Best regards,

								Pavel


> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -33,7 +33,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_softirq"
> +FUNC2="scheduler_tick"
>  
>  ALL_FUNCS="#### all functions enabled ####"


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH AUTOSEL 4.19 09/13] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

[Sasha Levin]

On Thu, Feb 24, 2022 at 11:46:22PM +0100, Pavel Machek wrote:
>On Tue 2022-02-22 21:31:48, Sasha Levin wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
>> [ Upstream commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 ]
>>
>> The PREEMPT_RT patchset does not use do_softirq() function thus trying
>> to filter for do_softirq fails for such kernel:
>>
>>   echo do_softirq
>>   ftracetest: 81: echo: echo: I/O error
>>
>> Choose some other visible function for the test.  The function does not
>> have to be actually executed during the test, because it is only testing
>> filter API interface.
>
>This needs -rt patch even on mainline, right?
>
>It is certainly not needed in -stable branches.

I'll drop it, thanks.

-- 
Thanks,
Sasha