public inbox for linux-kselftest@vger.kernel.org
 help / color / mirror / Atom feed
From: Joey Gouly <joey.gouly@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, nd@arm.com
Subject: Re: [PATCH v1 4/4] kselftest/arm64: Add simple test for MTE prctl
Date: Thu, 10 Mar 2022 15:33:06 +0000	[thread overview]
Message-ID: <20220310153306.GA53610@e124191.cambridge.arm.com> (raw)
In-Reply-To: <20220310144335.2097457-5-broonie@kernel.org>

Hi Mark,

On Thu, Mar 10, 2022 at 02:43:35PM +0000, Mark Brown wrote:
> The current tests use the prctls for various things but there's no
> coverage of the edges of the interface so add some basics. This isn't
> hugely useful as it is (it originally had some coverage for the
> combinations with asymmetric mode but we removed the prctl() for that)
> but it might be a helpful starting point for future work, for example
> covering error handling.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

[..]

> diff --git a/tools/testing/selftests/arm64/mte/check_prctl.c b/tools/testing/selftests/arm64/mte/check_prctl.c
> new file mode 100644
> index 000000000000..500aefc5d7cd
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/mte/check_prctl.c
> @@ -0,0 +1,123 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (C) 2022 ARM Limited
> +
> +#include <stdbool.h>
> +#include <stdio.h>
> +#include <string.h>
> +
> +#include <sys/auxv.h>
> +#include <sys/prctl.h>
> +
> +#include <asm/hwcap.h>
> +
> +#include "kselftest.h"
> +
> +static bool system_has_mte;

This looks unused (apart from being set in main()).

Thanks,
Joey

  reply	other threads:[~2022-03-10 15:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 14:43 [PATCH v1 0/4] kselftest/arm64: Miscelaneous MTE test updates Mark Brown
2022-03-10 14:43 ` [PATCH v1 1/4] kselftest/arm64: Handle more kselftest result codes in MTE helpers Mark Brown
2022-03-10 19:40   ` Shuah Khan
2022-03-10 14:43 ` [PATCH v1 2/4] kselftest/arm64: Log unexpected asynchronous MTE faults Mark Brown
2022-03-10 20:04   ` Shuah Khan
2022-03-10 14:43 ` [PATCH v1 3/4] kselftest/arm64: Refactor parameter checking in mte_switch_mode() Mark Brown
2022-03-10 20:05   ` Shuah Khan
2022-03-10 14:43 ` [PATCH v1 4/4] kselftest/arm64: Add simple test for MTE prctl Mark Brown
2022-03-10 15:33   ` Joey Gouly [this message]
2022-03-10 15:37     ` Mark Brown
2022-03-10 20:07   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310153306.GA53610@e124191.cambridge.arm.com \
    --to=joey.gouly@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=nd@arm.com \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox